cleanup to Value - fix for StringEscapesTest

frog/utils.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Collection<T> supports most of the ES 5 Array methods, but it's missing
 // map and reduce.
 
 // TODO(jmesserly): we might want a version of this that return an iterable,
 // however JS, Python and Ruby versions are all eager.
 List map(Iterable source, mapper(source)) {
@@ skipping 43 matching lines @@
   // TODO(jmesserly): it'd be nice to have SortedMap in corelib.
   List keys = map.getKeys();
   keys.sort((x, y) => x.compareTo(y));
   final values = [];
   for (var k in keys) {
     values.add(map[k]);
   }
   return values;
 }
 
-/** True if this is a triple quoted Dart string literal. */
-bool isMultilineString(String text) {
-  return text.startsWith('"""') || text.startsWith("'''");
-}
-
-bool isRawMultilineString(String text) {
-  return text.startsWith('@"""') || text.startsWith("@'''");
-}
-
-/**
- * Convert a single-quote string to be a double-quote string by replacing " with
- * \" and \' with '.
- */
-String toDoubleQuote(String s) {
-  return s.replaceAll('"', '\\"').replaceAll("\\'", "'");
-}
-
-
-// TODO(jmesserly): it'd be nice to deal with this in the tokenizer, rather than

[Jennifer Messerly, 2012/01/09 20:16:26]

yay, another todo--

-// taking another pass over the string.
-String parseStringLiteral(String lit) {
-  if (lit.startsWith('@')) {
-    if (isRawMultilineString(lit)) {
-      return stripLeadingNewline(lit.substring(4, lit.length - 3));
-    } else {
-      return lit.substring(2, lit.length - 1);
-    }
-  } else if (isMultilineString(lit)) {
-    lit = lit.substring(3, lit.length - 3).replaceAll('\\\$', '\$');
-    return stripLeadingNewline(lit);
-  } else {
-    return lit.substring(1, lit.length - 1).replaceAll('\\\$', '\$');
-  }
-}
-
-// The first newline in a multiline string is removed.
-String stripLeadingNewline(String text) {
-  if (text.startsWith('\n')) {
-    return text.substring(1);
-  } else if (text.startsWith('\r')) {
-    if (text.startsWith('\r\n')) {
-      return text.substring(2);
-    } else {
-      return text.substring(1);
-    }
-  } else {
-    return text;
-  }
-}
-
 /**
  * A [FixedCollection] is a collection of [length] items all of which have the
  * identical [value]
  */
 class FixedCollection<E> implements Collection<E> {
   final E value;
   final int length;
   const FixedCollection(this.value, this.length);
 
   Iterator<E> iterator() => new FixedIterator<E>(value, length);
@@ skipping 17 matching lines @@
     _index++;
     return value;
   }
 }
 
 // Color constants used for generating messages.
 String _GREEN_COLOR = '\u001b[32m';
 String _RED_COLOR = '\u001b[31m';
 String _MAGENTA_COLOR = '\u001b[35m';
 String _NO_COLOR = '\u001b[0m';