Issue 9119001: srpcgen: Use 'const char*' for string parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9119001: srpcgen: Use 'const char*' for string parameters (Closed)

Created:
8 years, 11 months ago by Roland McGrath

Modified:
8 years, 11 months ago

Reviewers:
sehr (please use chromium)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

srpcgen: Use 'const char*' for string parameters Mark string parameters as const. This avoids a compilation warning when passing a string constant as argument, and is generally good hygiene. BUG= none TEST= none R=sehr@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116572

Patch Set 1 #

Patch Set 2 : rebased; update year in copyright header srpcgen emits #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -47 lines)			Patch
M	ppapi/native_client/src/shared/ppapi_proxy/browser_nacl_file_rpc_server.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_rpc_server.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_rpc_server.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_client.cc	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppb_rpc_server.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_client.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_server.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppb_rpc.h	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppp_rpc.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/upcall.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppb_rpc.h	View	1	5 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppp_rpc.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/upcall.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/upcall_client.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/upcall_server.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/native_client/src/tools/srpcgen.py	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages