Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 9117020: update libsrtp gyp file (Closed)

Created:
8 years, 11 months ago by mallinath
Modified:
8 years, 11 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://src.chromium.org/svn/trunk/deps/third_party/
Visibility:
Public.

Description

libsrtp.gyp: fix incorrect headers path and remove unused math.c.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M libsrtp/libsrtp.gyp View 2 chunks +28 lines, -29 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
mallinath
Hi Sergey, Please review this CL with regards libsrtp gyp file.
8 years, 11 months ago (2012-01-24 04:39:50 UTC) #1
Sergey Ulanov
Please update CL description to describe what this CL is for. https://chromiumcodereview.appspot.com/9117020/diff/1/libsrtp/libsrtp.gyp File libsrtp/libsrtp.gyp (left): ...
8 years, 11 months ago (2012-01-24 04:56:55 UTC) #2
mallinath
https://chromiumcodereview.appspot.com/9117020/diff/1/libsrtp/libsrtp.gyp File libsrtp/libsrtp.gyp (left): https://chromiumcodereview.appspot.com/9117020/diff/1/libsrtp/libsrtp.gyp#oldcode158 libsrtp/libsrtp.gyp:158: 'srtp/crypto/math/math.c', math.c is not used when it's compiled and ...
8 years, 11 months ago (2012-01-24 06:28:57 UTC) #3
Sergey Ulanov
LGTM You can shorten the description to something like this: libsrtp.gyp: fix incorrect headers path ...
8 years, 11 months ago (2012-01-24 20:12:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@google.com/9117020/1
8 years, 11 months ago (2012-01-24 23:00:35 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-24 23:00:42 UTC) #6
Change committed as 118928

Powered by Google App Engine
This is Rietveld 408576698