Issue 9117009: Move |PlatformFont::GetStringWidth()| implementation up into font.cc directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9117009: Move |PlatformFont::GetStringWidth()| implementation up into font.cc directly. (Closed)

Created:
8 years, 11 months ago by Alexei Svitkine (slow)

Modified:
8 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Move |PlatformFont::GetStringWidth()| implementation up into font.cc directly. Also, add |CanvasSkia::GetStringWidth()| convenience method. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118899

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -35 lines)			Patch
M	ui/gfx/canvas_skia.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/gfx/canvas_skia.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ui/gfx/font.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/gfx/platform_font.h	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/platform_font_mac.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/platform_font_mac.mm	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/gfx/platform_font_pango.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/platform_font_pango.cc	View	1 2	2 chunks	+5 lines, -11 lines	0 comments	Download
M	ui/gfx/platform_font_win.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/platform_font_win.cc	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/9117009/21

8 years, 11 months ago (2012-01-24 19:07:50 UTC) #3

Change committed as 118899