Issue 9117001: For readability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9117001: For readability. (Closed)

Created:
8 years, 11 months ago by Avi (use Gerrit)

Modified:
8 years, 11 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), jshin+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add comment to NumberFormatWrapper. As noted in readability review. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117049

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Patch Set 3 : drop extraneous files #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	base/i18n/number_formatting.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

not much to say, looking really good. http://codereview.chromium.org/9117001/diff/1/base/i18n/number_formatting.cc File base/i18n/number_formatting.cc (right): http://codereview.chromium.org/9117001/diff/1/base/i18n/number_formatting.cc#newcode21 base/i18n/number_formatting.cc:21: struct NumberFormatWrapper ...

8 years, 11 months ago (2012-01-10 16:22:00 UTC) #1

Avi (use Gerrit)

Oops, forgot to not rebase; the only change is in response to your comment. http://codereview.chromium.org/9117001/diff/1/base/i18n/number_formatting.cc ...

8 years, 11 months ago (2012-01-10 16:35:34 UTC) #2

LGTM

Expand Messages | Collapse Messages