chrome/browser/resources/ntp4/page_switcher.js - Issue 9116037: [NTP4] Make TilePage and CardSlider evented to simplify code and fix page switcher bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/page_switcher.js

Issue 9116037: [NTP4] Make TilePage and CardSlider evented to simplify code and fix page switcher bug (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: found one more bug when you leave a tab while mousing over page switcher Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/ntp4/page_switcher.js

diff --git a/chrome/browser/resources/ntp4/page_switcher.js b/chrome/browser/resources/ntp4/page_switcher.js

index cf17ed5b263c76bb6b2f94715b583ad2cf7f089b..939a240add61eeddfe65f45b253065a54b98110e 100644

--- a/chrome/browser/resources/ntp4/page_switcher.js

+++ b/chrome/browser/resources/ntp4/page_switcher.js

@@ -32,7 +32,9 @@ cr.define('ntp4', function() {

activate_: function() {

var cardSlider = ntp4.getCardSlider();

- cardSlider.selectCard(cardSlider.currentCard + this.direction_, true);

+ var index = cardSlider.currentCard + this.direction_;

+ var numCards = cardSlider.cardCount - 1;

+ cardSlider.selectCard(Math.max(0, Math.min(index, numCards)), true);

/**

« no previous file with comments | « chrome/browser/resources/ntp4/page_list_view.js ('k') | chrome/browser/resources/ntp4/tile_page.js » ('j') | no next file with comments »