Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 9114057: Add an error message to the Javascript console when the NaCl plugin is blocked, (Closed)

Created:
8 years, 11 months ago by bbudge
Modified:
8 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add an error message to the Javascript console when the NaCl plugin is blocked, explaining why. BUG=100466 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
Please advise on the best way to send string to JS console.
8 years, 11 months ago (2012-01-11 02:50:15 UTC) #1
jam
I don't know what the best way is, but looks like other places in chrome/renderer ...
8 years, 11 months ago (2012-01-11 03:03:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/9114057/1
8 years, 11 months ago (2012-01-11 18:40:17 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 20:22:17 UTC) #4
Change committed as 117278

Powered by Google App Engine
This is Rietveld 408576698