Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/lib/integers.cc

Issue 9114054: Port a couple more stubs to x64. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator_x64.cc » ('j') | runtime/vm/cpu_x64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/integers.cc
===================================================================
--- runtime/lib/integers.cc (revision 3170)
+++ runtime/lib/integers.cc (working copy)
@@ -478,7 +478,11 @@
result = left.Value() << right.Value();
break;
case Token::kSAR: {
+#if defined(TARGET_ARCH_X64) // TODO(regis): Revisit.
+ int shift_amount = (right.Value() > 0x3F) ? 0x3F : right.Value();
+#else
int shift_amount = (right.Value() > 0x1F) ? 0x1F : right.Value();
+#endif
result = left.Value() >> shift_amount;
break;
}
« no previous file with comments | « no previous file | runtime/vm/code_generator_x64.cc » ('j') | runtime/vm/cpu_x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698