dart/frog/leg/ssa/nodes.dart - Issue 9114053: Record names of constructors and use that to implement Object.toString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/leg/ssa/nodes.dart

Issue 9114053: Record names of constructors and use that to implement Object.toString. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Avoid constant folding Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/frog/leg/ssa/nodes.dart

diff --git a/dart/frog/leg/ssa/nodes.dart b/dart/frog/leg/ssa/nodes.dart

index e5ab8ac70cc400914689cbe0e5c90039089af1cc..d9823104de7939f60ea9936f7524d33f00bbac3b 100644

--- a/dart/frog/leg/ssa/nodes.dart

+++ b/dart/frog/leg/ssa/nodes.dart

@@ -1197,7 +1197,6 @@ class HAdd extends HBinaryArithmetic {

}

if (right.isString()) return HType.STRING;

if (isNumber() || left.isNumber() || right.isNumber()) return HType.NUMBER;

- if (type.isUnknown()) return HType.NUMBER;

ngeoffray 2012/01/11 12:30:13 Crying :-)

return HType.UNKNOWN;

}

« no previous file with comments | « dart/frog/leg/lib/core.dart ('k') | dart/frog/tests/leg_only/src/ToStringTest.dart » ('j') | no next file with comments »