Add primitive WebGL ArrayBuffer() support to d8

test/mjsunit/external-array.js

 // Copyright 2011 the V8 project authors. All rights reserved.

[Jakob Kummerow, 2012/01/11 13:54:27]

2012

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
@@ skipping 24 matching lines @@
 var a = new Int32Array(2);
 for (var i = 0; i < 5; i++) {
   f(a);
 }
 %OptimizeFunctionOnNextCall(f);
 f(a);
 
 assertEquals(0, a[0]);
 assertEquals(0, a[1]);
 
+// No-parameter constructor should fail right now.
+function abfunc1() {
+  return new ArrayBuffer();
+}
+assertThrows(abfunc1);
+
+// Test derivation from an ArrayBuffer
+var ab = new ArrayBuffer(12);
+var derived_uint8 = new Uint8Array(ab);
+assertEquals(12, derived_uint8.length);
+var derived_uint32 = new Uint32Array(ab);
+assertEquals(3, derived_uint32.length);
+var derived_uint32_2 = new Uint32Array(ab,4);
+assertEquals(2, derived_uint32_2.length);
+var derived_uint32_3 = new Uint32Array(ab,4,1);
+assertEquals(1, derived_uint32_3.length);
+
+function abfunc2() {
+  new Uint32Array(ab,3);
+}
+assertThrows(abfunc2);
+
+// If a given byteOffset and length references an area beyond the end of the
+// ArrayBuffer an exception is raised.
+function abfunc3() {
+  new Uint32Array(ab,4,3);
+}
+assertThrows(abfunc3);
+function abfunc4() {
+  new Uint32Array(ab,13);

[Jakob Kummerow, 2012/01/11 13:54:27]

s/13/16/ to avoid triggering the "offset must be multiple of element size" code
path. 

[danno, 2012/01/11 15:10:20]

Done.

+}
+assertThrows(abfunc4);
+
+// The given byteOffset must be a multiple of the element size of the specific
+// type, otherwise an exception is raised.
+function abfunc5() {

[Jakob Kummerow, 2012/01/11 13:54:27]

nit: AFAICS, abfunc5 and abfunc2 test the same thing.

[danno, 2012/01/11 15:10:20]

Done.

+  new Uint32Array(ab,5);
+}
+assertThrows(abfunc5);
+
+// If length is not explicitly specified, the length of the ArrayBuffer minus
+// the byteOffset must be a multiple of the element size of the specific type,
+// or an exception is raised.
+var ab2 = new ArrayBuffer(13);
+function abfunc6() {
+  new Uint32Array(ab,1);

[Jakob Kummerow, 2012/01/11 13:54:27]

This doesn't test what the comment says (13-1 is, in fact, a multiple of 4, but
an exception is thrown nevertheless, because the offset must be a multiple of
the element size too).
What you mean is "new Uint32Array(ab, 4);".

+}
+assertThrows(abfunc6);
+
 // Test the correct behavior of the |BYTES_PER_ELEMENT| property (which is
 // "constant", but not read-only).
 a = new Int32Array(2);
 assertEquals(4, a.BYTES_PER_ELEMENT);
 a.BYTES_PER_ELEMENT = 42;
 assertEquals(42, a.BYTES_PER_ELEMENT);
 a = new Uint8Array(2);
 assertEquals(1, a.BYTES_PER_ELEMENT);
 a = new Int16Array(2);
 assertEquals(2, a.BYTES_PER_ELEMENT);
@@ skipping 210 matching lines @@
     return a[0] = a[0] = 1;
   }
 
   array_load_set_smi_check2(a);
   %OptimizeFunctionOnNextCall(array_load_set_smi_check2);
   array_load_set_smi_check2(a);
   array_load_set_smi_check2(0);
   %DeoptimizeFunction(array_load_set_smi_check2);
   gc();  // Makes V8 forget about type information for array_load_set_smi_check.
 }