Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9114047: Move RenderViewHostDelegateViewHelper to content. (Closed)

Created:
8 years, 11 months ago by Avi (use Gerrit)
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, brettw-cc_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Move RenderViewHostDelegateViewHelper to content. Rename to be something less of a tongue-twister. BUG=93804, 95573 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117220 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=117222 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117277

Patch Set 1 #

Total comments: 4

Patch Set 2 : slight cleanup #

Patch Set 3 : rebase #

Patch Set 4 : CONTENT_EXPORT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -369 lines) Patch
D chrome/browser/tab_contents/render_view_host_delegate_helper.h View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 chunk +0 lines, -180 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 4 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
A + content/browser/tab_contents/tab_contents_view_helper.h View 1 2 3 3 chunks +13 lines, -11 lines 0 comments Download
A + content/browser/tab_contents/tab_contents_view_helper.cc View 1 8 chunks +10 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Avi (use Gerrit)
Been too long since I tossed you a CL.
8 years, 11 months ago (2012-01-10 22:04:21 UTC) #1
Avi (use Gerrit)
Jochen for general Scott for OWNERship of chrome/browser/ui
8 years, 11 months ago (2012-01-10 22:11:47 UTC) #2
sky
chrome/browser/ui LGTM
8 years, 11 months ago (2012-01-10 23:19:27 UTC) #3
jochen (gone - plz use gerrit)
lgtm http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.h File content/browser/tab_contents/tab_contents_view_helper.h (right): http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.h#newcode83 content/browser/tab_contents/tab_contents_view_helper.h:83: // Tracks created RenderViewHost objects that have not ...
8 years, 11 months ago (2012-01-10 23:25:59 UTC) #4
Avi (use Gerrit)
http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.h File content/browser/tab_contents/tab_contents_view_helper.h (right): http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.h#newcode83 content/browser/tab_contents/tab_contents_view_helper.h:83: // Tracks created RenderViewHost objects that have not been ...
8 years, 11 months ago (2012-01-11 03:17:11 UTC) #5
jam
http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.cc File content/browser/tab_contents/tab_contents_view_helper.cc (right): http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.cc#newcode87 content/browser/tab_contents/tab_contents_view_helper.cc:87: content::WebContents* web_contents, nit: why add content::WebContents everywhere? all the ...
8 years, 11 months ago (2012-01-11 03:27:42 UTC) #6
Avi (use Gerrit)
http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.cc File content/browser/tab_contents/tab_contents_view_helper.cc (right): http://codereview.chromium.org/9114047/diff/1/content/browser/tab_contents/tab_contents_view_helper.cc#newcode87 content/browser/tab_contents/tab_contents_view_helper.cc:87: content::WebContents* web_contents, Um.. Why did this seem like a ...
8 years, 11 months ago (2012-01-11 03:34:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9114047/9002
8 years, 11 months ago (2012-01-11 17:26:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/9114047/9020
8 years, 11 months ago (2012-01-11 18:38:52 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-11 20:19:10 UTC) #10 
Can't apply patch for file chrome/browser/tab_contents/tab_contents_view_mac.h.
While running patch -p1 --forward --force;
patching file chrome/browser/tab_contents/tab_contents_view_mac.h
Hunk #1 FAILED at 1.
Hunk #3 succeeded at 128 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file
chrome/browser/tab_contents/tab_contents_view_mac.h.rej

Powered by Google App Engine
This is Rietveld 408576698