chrome/browser/resources/file_manager/main.html - Issue 9114040: Update thumbnail/list view buttons.

Side by Side Diff: chrome/browser/resources/file_manager/main.html

Issue 9114040: Update thumbnail/list view buttons. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: "Add asset files." Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <!--	2 <!--

3 -- Copyright (c) 2011 The Chromium Authors. All rights reserved.	3 -- Copyright (c) 2011 The Chromium Authors. All rights reserved.
	flackr 2012/01/10 22:02:55 s/2011/2012 s/2011/2012 bshe 2012/01/11 01:16:21 Done. Show quoted text On 2012/01/10 22:02:55, flackr wrote: > s/2011/2012 Done.
4 -- Use of this source code is governed by a BSD-style license that can be	4 -- Use of this source code is governed by a BSD-style license that can be

5 -- found in the LICENSE file.	5 -- found in the LICENSE file.

6 -->	6 -->

7 <html i18n-values="dir:textdirection;">	7 <html i18n-values="dir:textdirection;">

8 <head>	8 <head>

9 <if expr="0">	9 <if expr="0">

10 <!-- <if ... /if> is removed while flattening HTML. -->	10 <!-- <if ... /if> is removed while flattening HTML. -->

11 <base href="">	11 <base href="">

12 <script>	12 <script>

13 // Instruction for enabling loading file manager files remotely (speeds up	13 // Instruction for enabling loading file manager files remotely (speeds up

(...skipping 121 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
135 >[TITLE]</div>	135 >[TITLE]</div>

136 <div class=dialog-container>	136 <div class=dialog-container>

137 <div class=dialog-sidebar>	137 <div class=dialog-sidebar>

138 <div class=close-sidebar><img src='images/close_sidebar.png'></div>	138 <div class=close-sidebar><img src='images/close_sidebar.png'></div>

139 <list class=roots-list></list>	139 <list class=roots-list></list>

140 </div>	140 </div>

141 <div class=dialog-main>	141 <div class=dialog-main>

142 <div class=dialog-header>	142 <div class=dialog-header>

143 <div class=open-sidebar><img src='images/open_sidebar.png'></div>	143 <div class=open-sidebar><img src='images/open_sidebar.png'></div>

144 <div class=breadcrumbs></div>	144 <div class=breadcrumbs></div>

145 <button class=detail-view tabindex=4	145 <div><button class=detail-view tabindex=4 disabled></button></div>
	flackr 2012/01/10 22:02:55 Get rid of the surrounding div if it is not being Get rid of the surrounding div if it is not being used for anything. bshe 2012/01/11 01:16:21 Sorry. I should add a comment here. The surroundin Sorry. I should add a comment here. The surrounding div is a hack to get rid of the margin between the two buttons. Matt mentioned that you and him have seen the margin problem before. On 2012/01/10 22:02:55, flackr wrote: Show quoted text > Get rid of the surrounding div if it is not being used for anything.
146 ><img src='images/icon-detail-view.png'></button	146 <div><button class=thumbnail-view tabindex=5></button></div>
	flackr 2012/01/10 22:02:55 All of the styles in file_manager are wrong (I.e. All of the styles in file_manager are wrong (I.e. attribute values should be quoted with double quotes in html files, css belongs in css files, scripts belong in js files.) I hate to see more code go in preserving the bad style. Perhaps you could file a bug to track cleaning up the code in this directory. bshe 2012/01/11 01:16:21 Done. Tracked in chromium-os:24926 Show quoted text On 2012/01/10 22:02:55, flackr wrote: > All of the styles in file_manager are wrong (I.e. attribute values should be > quoted with double quotes in html files, css belongs in css files, scripts > belong in js files.) I hate to see more code go in preserving the bad style. > Perhaps you could file a bug to track cleaning up the code in this directory. Done. Tracked in chromium-os:24926
147 ><button class=thumbnail-view tabindex=5

148 ><img src='images/icon-thumb-view.png'></button>

149 </div>	147 </div>

150 <div class=dialog-body>	148 <div class=dialog-body>

151 <div class=filelist-panel>	149 <div class=filelist-panel>

152 <div class=list-container>	150 <div class=list-container>

153 <div class=detail-table tabindex=0></div>	151 <div class=detail-table tabindex=0></div>

154 <grid class=thumbnail-grid tabindex=0></grid>	152 <grid class=thumbnail-grid tabindex=0></grid>

155 </div>	153 </div>

156 <div class=downloads-warning hidden>	154 <div class=downloads-warning hidden>

157 <img src=images/warning_icon_square_26x26.png>	155 <img src=images/warning_icon_square_26x26.png>

158 <div></div>	156 <div></div>

(...skipping 25 matching lines...) Expand all Loading...
184 visibleif='this.dialogType_ == "saveas-file"'>	182 visibleif='this.dialogType_ == "saveas-file"'>

185 <div class=horizontal-spacer></div>	183 <div class=horizontal-spacer></div>

186 <button class=ok disabled tabindex=2>[OK]</button>	184 <button class=ok disabled tabindex=2>[OK]</button>

187 <button class=cancel tabindex=3 i18n-content=CANCEL_LABEL	185 <button class=cancel tabindex=3 i18n-content=CANCEL_LABEL

188 >[CANCEL]</button>	186 >[CANCEL]</button>

189 </div>	187 </div>

190	188

191 <script>init();</script>	189 <script>init();</script>

192 </body>	190 </body>

193 </html>	191 </html>

OLD	NEW

« chrome/browser/resources/file_manager/css/file_manager.css ('K') | « chrome/browser/resources/file_manager/images/icon_thumb_view_on.png ('k') | no next file » | no next file with comments »