Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 9114009: Prepare push to trunk. Now working on version 3.8.6. (Closed)

Created:
8 years, 11 months ago by rossberg
Modified:
8 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 3.8.6. R=yangguo@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10345

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Yang's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +26 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rossberg
8 years, 11 months ago (2012-01-05 14:43:29 UTC) #1
Yang
On 2012/01/05 14:43:29, rossberg wrote: LGTM with comments.
8 years, 11 months ago (2012-01-05 14:52:47 UTC) #2
Yang
Comments... http://codereview.chromium.org/9114009/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/9114009/diff/1/ChangeLog#newcode10 ChangeLog:10: Determine page size at runtime on posix platforms. ...
8 years, 11 months ago (2012-01-05 14:53:02 UTC) #3
Yang
On 2012/01/05 14:53:02, Yang wrote: > Comments... > > http://codereview.chromium.org/9114009/diff/1/ChangeLog > File ChangeLog (right): > ...
8 years, 11 months ago (2012-01-05 14:56:14 UTC) #4
rossberg
8 years, 11 months ago (2012-01-05 14:56:14 UTC) #5
http://codereview.chromium.org/9114009/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/9114009/diff/1/ChangeLog#newcode10
ChangeLog:10: Determine page size at runtime on posix platforms.  Landing for
On 2012/01/05 14:53:02, Yang wrote:
> Do we want to have the line "Landing for kalmard" and the code review link in
> there?

Done.

http://codereview.chromium.org/9114009/diff/1/ChangeLog#newcode24
ChangeLog:24: Update LICENSE file
On 2012/01/05 14:53:02, Yang wrote:
> I think this line is unnecessary.

Done.

Powered by Google App Engine
This is Rietveld 408576698