Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9114: Do not put failures in handles.... (Closed)

Created:
12 years, 1 month ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Do not put failures in handles. Assert in the Handle constructor that the object is not a failure. I have run our own tests in debug mode and the WebKit layout tests in debug mode and there are no regressions. Committed: http://code.google.com/p/v8/source/detail?r=691

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M src/codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/execution.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M src/handles-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/messages.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 4 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
12 years, 1 month ago (2008-11-04 15:41:34 UTC) #1
Mads Ager (chromium)
12 years, 1 month ago (2008-11-04 15:44:54 UTC) #2 
Kevin, since Kasper is traveling, could you take a look at this one too?

Powered by Google App Engine
This is Rietveld 408576698