Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/resources/options2/certificate_backup_overlay.js

Issue 9113052: [uber page] Cleaning up some nits I found while mucking around in options2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jhawkins' review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 const OptionsPage = options.OptionsPage; 6 const OptionsPage = options.OptionsPage;
7 7
8 /** 8 /**
9 * CertificateBackupOverlay class 9 * CertificateBackupOverlay class
10 * Encapsulated handling of the 'enter backup password' overlay page. 10 * Encapsulated handling of the 'enter backup password' overlay page.
(...skipping 12 matching lines...) Expand all
23 23
24 /** 24 /**
25 * Initializes the page. 25 * Initializes the page.
26 */ 26 */
27 initializePage: function() { 27 initializePage: function() {
28 OptionsPage.prototype.initializePage.call(this); 28 OptionsPage.prototype.initializePage.call(this);
29 29
30 var self = this; 30 var self = this;
31 $('certificateBackupCancelButton').onclick = function(event) { 31 $('certificateBackupCancelButton').onclick = function(event) {
32 self.cancelBackup_(); 32 self.cancelBackup_();
33 } 33 };
34 $('certificateBackupOkButton').onclick = function(event) { 34 $('certificateBackupOkButton').onclick = function(event) {
35 self.finishBackup_(); 35 self.finishBackup_();
36 } 36 };
37 $('certificateBackupPassword').oninput = 37 var onBackupPasswordInput = function(event) {
38 $('certificateBackupPassword2').oninput = function(event) {
39 self.comparePasswords_(); 38 self.comparePasswords_();
40 } 39 };
40 $('certificateBackupPassword').oninput = onBackupPasswordInput;
41 $('certificateBackupPassword2').oninput = onBackupPasswordInput;
41 42
42 self.clearInputFields_(); 43 self.clearInputFields_();
43 }, 44 },
44 45
45 /** 46 /**
46 * Clears any uncommitted input, and dismisses the overlay. 47 * Clears any uncommitted input, and dismisses the overlay.
47 * @private 48 * @private
48 */ 49 */
49 dismissOverlay_: function() { 50 dismissOverlay_: function() {
50 this.clearInputFields_(); 51 this.clearInputFields_();
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 108
108 CertificateBackupOverlay.dismiss = function() { 109 CertificateBackupOverlay.dismiss = function() {
109 CertificateBackupOverlay.getInstance().dismissOverlay_(); 110 CertificateBackupOverlay.getInstance().dismissOverlay_();
110 }; 111 };
111 112
112 // Export 113 // Export
113 return { 114 return {
114 CertificateBackupOverlay: CertificateBackupOverlay 115 CertificateBackupOverlay: CertificateBackupOverlay
115 }; 116 };
116 }); 117 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698