Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: chrome/browser/resources/options2/alert_overlay.js

Issue 9113052: [uber page] Cleaning up some nits I found while mucking around in options2. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: jhawkins' review comments Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 var OptionsPage = options.OptionsPage; 6 var OptionsPage = options.OptionsPage;
7 7
8 /** 8 /**
9 * AlertOverlay class 9 * AlertOverlay class
10 * Encapsulated handling of a generic alert. 10 * Encapsulated handling of a generic alert.
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 } 128 }
129 129
130 var alertOverlay = AlertOverlay.getInstance(); 130 var alertOverlay = AlertOverlay.getInstance();
131 alertOverlay.okCallback = okCallback; 131 alertOverlay.okCallback = okCallback;
132 alertOverlay.cancelCallback = cancelCallback; 132 alertOverlay.cancelCallback = cancelCallback;
133 alertOverlay.canShow_ = true; 133 alertOverlay.canShow_ = true;
134 134
135 // Intentionally don't show the URL in the location bar as we don't want 135 // Intentionally don't show the URL in the location bar as we don't want
136 // people trying to navigate here by hand. 136 // people trying to navigate here by hand.
137 OptionsPage.showPageByName('alertOverlay', false); 137 OptionsPage.showPageByName('alertOverlay', false);
138 } 138 };
139 139
140 // Export 140 // Export
141 return { 141 return {
142 AlertOverlay: AlertOverlay 142 AlertOverlay: AlertOverlay
143 }; 143 };
144 }); 144 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698