[uber page] Cleaning up some nits I found while mucking around in options2.

[uber page] Cleaning up some nits I found while mucking around in options2.

R=tbreisacher@chromium.org
BUG=110658
TEST=My eyes don't get angry?

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119202

[Dan Beam, 2012-01-25 06:44:31]

actually, tbresaicher can take a look at this one

[Tyler Breisacher (Chromium), 2012-01-25 07:01:13]

On 2012/01/25 06:44:31, Dan Beam wrote:
> actually, tbresaicher can take a look at this one

Nice. This will make it easier to put this in place:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...
so thank you.

LGTM (with one comment) but since I'm still provisional you'll also need someone
else to review it.

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options2/certificate_backup_overlay.js (right):

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/certificate_backup_overlay.js:37:
$('certificateBackupPassword').oninput =
While we're here, this looks like an incomplete statement. It's actually one
long statement that does two assignments at once:

$('cBP') = $('cBP2') = function(...) {...

But in that case, we should indent line 38 by 4 spaces, I think.

[Dan Beam, 2012-01-25 07:14:52]

+jhawkins for OWNERS stamp / review / outstanding nit

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options2/certificate_backup_overlay.js (right):

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/certificate_backup_overlay.js:37:
$('certificateBackupPassword').oninput =
On 2012/01/25 07:01:14, tbreisacher wrote:
> While we're here, this looks like an incomplete statement. It's actually one
> long statement that does two assignments at once:
> 
> $('cBP') = $('cBP2') = function(...) {...
> 
> But in that case, we should indent line 38 by 4 spaces, I think.

I'll add jhawkins as I need a committer and OWNERS stamp from him anyways.  I'm
not totally sure what the preferred indentation is here (if there is one), never
hit a case like this.  The other solution would be to simply make this into a FD
or NFE and set it equal to both.

[James Hawkins, 2012-01-26 01:38:04]

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options2/certificate_backup_overlay.js (right):

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/certificate_backup_overlay.js:37:
$('certificateBackupPassword').oninput =
On 2012/01/25 07:14:52, Dan Beam wrote:
> On 2012/01/25 07:01:14, tbreisacher wrote:
> > While we're here, this looks like an incomplete statement. It's actually one
> > long statement that does two assignments at once:
> > 
> > $('cBP') = $('cBP2') = function(...) {...
> > 
> > But in that case, we should indent line 38 by 4 spaces, I think.
> 
> I'll add jhawkins as I need a committer and OWNERS stamp from him anyways. 
I'm
> not totally sure what the preferred indentation is here (if there is one),
never
> hit a case like this.  The other solution would be to simply make this into a
FD
> or NFE and set it equal to both.

Indentation is required, so I'd prefer a temp var to set both to instead.

[Dan Beam, 2012-01-26 04:00:36]

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options2/certificate_backup_overlay.js (right):

http://codereview.chromium.org/9113052/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options2/certificate_backup_overlay.js:37:
$('certificateBackupPassword').oninput =
On 2012/01/26 01:38:04, James Hawkins wrote:
> On 2012/01/25 07:14:52, Dan Beam wrote:
> > On 2012/01/25 07:01:14, tbreisacher wrote:
> > > While we're here, this looks like an incomplete statement. It's actually
one
> > > long statement that does two assignments at once:
> > > 
> > > $('cBP') = $('cBP2') = function(...) {...
> > > 
> > > But in that case, we should indent line 38 by 4 spaces, I think.
> > 
> > I'll add jhawkins as I need a committer and OWNERS stamp from him anyways. 
> I'm
> > not totally sure what the preferred indentation is here (if there is one),
> never
> > hit a case like this.  The other solution would be to simply make this into
a
> FD
> > or NFE and set it equal to both.
> 
> Indentation is required, so I'd prefer a temp var to set both to instead.

Done.

[James Hawkins, 2012-01-26 04:09:57]

LGTM though I was fine with you going blind.

[commit-bot: I haz the power, 2012-01-26 04:50:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/9113052/6001

[commit-bot: I haz the power, 2012-01-26 06:51:46]

Change committed as 119202