Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2493)

Unified Diff: ash/wm/workspace_controller_unittest.cc

Issue 9113045: Reworks the workspace code. Here's the new heuristics: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated feedback and fixed bugs Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace_controller_unittest.cc
diff --git a/ash/wm/workspace_controller_unittest.cc b/ash/wm/workspace_controller_unittest.cc
index 5438a6ff715a77291c264816c1b1961e380f5216..c6ddfb854b359ac2cc365ab75d21df4557e7fcea 100644
--- a/ash/wm/workspace_controller_unittest.cc
+++ b/ash/wm/workspace_controller_unittest.cc
@@ -67,53 +67,5 @@ class WorkspaceControllerTest : public aura::test::AuraTestBase {
DISALLOW_COPY_AND_ASSIGN(WorkspaceControllerTest);
};
-TEST_F(WorkspaceControllerTest, Overview) {
- workspace_manager()->SetWorkspaceSize(gfx::Size(500, 300));
-
- // Creating two workspaces, ws1 which contains window w1,
- // and ws2 which contains window w2.
- Workspace* ws1 = workspace_manager()->CreateWorkspace();
- scoped_ptr<Window> w1(CreateTestWindow());
- EXPECT_TRUE(ws1->AddWindowAfter(w1.get(), NULL));
-
- Workspace* ws2 = workspace_manager()->CreateWorkspace();
- scoped_ptr<Window> w2(CreateTestWindow());
- EXPECT_TRUE(ws2->AddWindowAfter(w2.get(), NULL));
-
- // Activating a window switches the active workspace.
- ash::ActivateWindow(w2.get());
- EXPECT_EQ(ws2, workspace_manager()->GetActiveWorkspace());
-
- // The size of contents_view() is now ws1(500) + ws2(500) + margin(50).
- EXPECT_EQ("0,0 1050x300", contents_view()->bounds().ToString());
- EXPECT_FALSE(workspace_manager()->is_overview());
- workspace_manager()->SetOverview(true);
- EXPECT_TRUE(workspace_manager()->is_overview());
-
- // Switching overview mode doesn't change the active workspace.
- EXPECT_EQ(ws2, workspace_manager()->GetActiveWorkspace());
-
- // Activating window w1 switches the active window and
- // the mode back to normal mode.
- ash::ActivateWindow(w1.get());
- EXPECT_EQ(ws1, workspace_manager()->GetActiveWorkspace());
- EXPECT_FALSE(workspace_manager()->is_overview());
-
- // Deleting w1 without StackingClient resets the active workspace
- ws1->RemoveWindow(w1.get());
- delete ws1;
- w1.reset();
- EXPECT_EQ(ws2, workspace_manager()->GetActiveWorkspace());
- EXPECT_EQ("0,0 500x300", contents_view()->bounds().ToString());
- ws2->RemoveWindow(w2.get());
- delete ws2;
- // The size of contents_view() for no workspace case must be
- // same as one contents_view() case.
- EXPECT_EQ("0,0 500x300", contents_view()->bounds().ToString());
-
- // Reset now before windows are destroyed.
- controller_.reset();
-}
-
} // namespace internal
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698