Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 9113033: GTK: More raw struct access removal, this time focusing on GtkDialog. (Closed)

Created:
8 years, 11 months ago by Elliot Glaysher
Modified:
8 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, yoshiki+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: More raw struct access removal, this time focusing on GtkDialog. BUG=79722 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/certificate_viewer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/edit_search_engine_dialog.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/external_protocol_dialog_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/html_dialog_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/instant_confirm_dialog_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/task_manager_gtk.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/update_recommended_dialog.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
8 years, 11 months ago (2012-01-06 02:21:55 UTC) #1
Lei Zhang
lgtm
8 years, 11 months ago (2012-01-06 09:36:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9113033/1
8 years, 11 months ago (2012-01-06 18:09:57 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-06 19:44:04 UTC) #4
Change committed as 116717

Powered by Google App Engine
This is Rietveld 408576698