Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/sync/engine/verify_updates_command.cc

Issue 9113024: Add return values to SyncerCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update for review comments Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/verify_updates_command.cc
diff --git a/chrome/browser/sync/engine/verify_updates_command.cc b/chrome/browser/sync/engine/verify_updates_command.cc
index 96dd4e7f310bbb506e8436029a027197333cbbe6..dcf5ecba552ab83971e2372bb0fcfac0804039ac 100644
--- a/chrome/browser/sync/engine/verify_updates_command.cc
+++ b/chrome/browser/sync/engine/verify_updates_command.cc
@@ -42,14 +42,14 @@ std::set<ModelSafeGroup> VerifyUpdatesCommand::GetGroupsToChange(
return groups_with_updates;
}
-void VerifyUpdatesCommand::ModelChangingExecuteImpl(
+SyncerError VerifyUpdatesCommand::ModelChangingExecuteImpl(
sessions::SyncSession* session) {
DVLOG(1) << "Beginning Update Verification";
ScopedDirLookup dir(session->context()->directory_manager(),
session->context()->account_name());
if (!dir.good()) {
LOG(ERROR) << "Scoped dir lookup failed!";
- return;
+ return DIRECTORY_LOOKUP_FAILED;
}
WriteTransaction trans(FROM_HERE, SYNCER, dir);
sessions::StatusController* status = session->mutable_status_controller();
@@ -72,6 +72,8 @@ void VerifyUpdatesCommand::ModelChangingExecuteImpl(
if (update.deleted())
status->increment_num_tombstone_updates_downloaded_by(1);
}
+
+ return NO_ERROR;
}
namespace {

Powered by Google App Engine
This is Rietveld 408576698