Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/sync/engine/store_timestamps_command.cc

Issue 9113024: Add return values to SyncerCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update for review comments Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/store_timestamps_command.cc
diff --git a/chrome/browser/sync/engine/store_timestamps_command.cc b/chrome/browser/sync/engine/store_timestamps_command.cc
index 140191b4d0e1b727dabf852951253f35d70126e4..a8c83a9c01d4be6cccabcd949ed6af79ccb7048b 100644
--- a/chrome/browser/sync/engine/store_timestamps_command.cc
+++ b/chrome/browser/sync/engine/store_timestamps_command.cc
@@ -15,13 +15,14 @@ namespace browser_sync {
StoreTimestampsCommand::StoreTimestampsCommand() {}
StoreTimestampsCommand::~StoreTimestampsCommand() {}
-void StoreTimestampsCommand::ExecuteImpl(sessions::SyncSession* session) {
+SyncerError StoreTimestampsCommand::ExecuteImpl(
+ sessions::SyncSession* session) {
syncable::ScopedDirLookup dir(session->context()->directory_manager(),
session->context()->account_name());
if (!dir.good()) {
LOG(ERROR) << "Scoped dir lookup failed!";
- return;
+ return DIRECTORY_LOOKUP_FAILED;
}
const GetUpdatesResponse& updates =
@@ -58,6 +59,8 @@ void StoreTimestampsCommand::ExecuteImpl(sessions::SyncSession* session) {
DVLOG(1) << "Changes remaining: " << changes_left;
status->set_num_server_changes_remaining(changes_left);
}
+
+ return NO_ERROR;
}
} // namespace browser_sync

Powered by Google App Engine
This is Rietveld 408576698