Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8256)

Unified Diff: chrome/browser/sync/engine/get_commit_ids_command.cc

Issue 9113024: Add return values to SyncerCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update for review comments Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/get_commit_ids_command.cc
diff --git a/chrome/browser/sync/engine/get_commit_ids_command.cc b/chrome/browser/sync/engine/get_commit_ids_command.cc
index 720c063f23d13663a8e7cc5f34ec3340dbbb7203..fcdbdb69b02fc9cca1873925bae5a5aeedb14390 100644
--- a/chrome/browser/sync/engine/get_commit_ids_command.cc
+++ b/chrome/browser/sync/engine/get_commit_ids_command.cc
@@ -29,7 +29,7 @@ GetCommitIdsCommand::GetCommitIdsCommand(int commit_batch_size)
GetCommitIdsCommand::~GetCommitIdsCommand() {}
-void GetCommitIdsCommand::ExecuteImpl(SyncSession* session) {
+SyncerError GetCommitIdsCommand::ExecuteImpl(SyncSession* session) {
// Gather the full set of unsynced items and store it in the session. They
// are not in the correct order for commit.
syncable::Directory::UnsyncedMetaHandles all_unsynced_handles;
@@ -65,6 +65,7 @@ void GetCommitIdsCommand::ExecuteImpl(SyncSession* session) {
DVLOG(1) << "Debug commit batch result:" << verified_commit_ids[i];
status->set_commit_set(*ordered_commit_set_.get());
+ return NO_ERROR;
}
namespace {

Powered by Google App Engine
This is Rietveld 408576698