Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/browser/sync/engine/process_commit_response_command.h

Issue 9113024: Add return values to SyncerCommand (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move syncer_error.* to internal_api/includes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/process_commit_response_command.h
diff --git a/chrome/browser/sync/engine/process_commit_response_command.h b/chrome/browser/sync/engine/process_commit_response_command.h
index bac2a31770e55e7dbe5badc2517c3c8d1c7c7920..e6762a296e6431ad66b9b9f37a8144060b43de70 100644
--- a/chrome/browser/sync/engine/process_commit_response_command.h
+++ b/chrome/browser/sync/engine/process_commit_response_command.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -32,9 +32,9 @@ class ProcessCommitResponseCommand : public ModelChangingSyncerCommand {
// ModelChangingSyncerCommand implementation.
virtual std::set<ModelSafeGroup> GetGroupsToChange(
const sessions::SyncSession& session) const OVERRIDE;
- virtual bool ModelNeutralExecuteImpl(
+ virtual SyncerError ModelNeutralExecuteImpl(
sessions::SyncSession* session) OVERRIDE;
- virtual void ModelChangingExecuteImpl(
+ virtual SyncerError ModelChangingExecuteImpl(
sessions::SyncSession* session) OVERRIDE;
private:
@@ -47,7 +47,7 @@ class ProcessCommitResponseCommand : public ModelChangingSyncerCommand {
std::set<syncable::Id>* deleted_folders);
// Actually does the work of execute.
- void ProcessCommitResponse(sessions::SyncSession* session);
+ SyncerError ProcessCommitResponse(sessions::SyncSession* session);
void ProcessSuccessfulCommitResponse(
const sync_pb::SyncEntity& committed_entry,

Powered by Google App Engine
This is Rietveld 408576698