Add return values to SyncerCommand

chrome/browser/sync/engine/build_commit_command.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/build_commit_command.h"
 
 #include <limits>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 67 matching lines @@
 namespace {
 void SetEntrySpecifics(MutableEntry* meta_entry, SyncEntity* sync_entry) {
   // Add the new style extension and the folder bit.
   sync_entry->mutable_specifics()->CopyFrom(meta_entry->Get(SPECIFICS));
   sync_entry->set_folder(meta_entry->Get(syncable::IS_DIR));
 
   DCHECK(meta_entry->GetModelType() == sync_entry->GetModelType());
 }
 }  // namespace
 
-void BuildCommitCommand::ExecuteImpl(SyncSession* session) {
+SyncerError BuildCommitCommand::ExecuteImpl(SyncSession* session) {
   ClientToServerMessage message;
   message.set_share(session->context()->account_name());
   message.set_message_contents(ClientToServerMessage::COMMIT);
 
   CommitMessage* commit_message = message.mutable_commit();
   commit_message->set_cache_guid(
       session->write_transaction()->directory()->cache_guid());
   AddExtensionsActivityToMessage(session, commit_message);
   SyncerProtoUtil::AddRequestBirthday(
       session->write_transaction()->directory(), &message);
@@ skipping 104 matching lines @@
                                                    position_block.second);
 
         position_map[id] = position_block;
         sync_entry->set_position_in_parent(position_block.first);
       }
       SetEntrySpecifics(&meta_entry, sync_entry);
     }
   }
   session->mutable_status_controller()->
       mutable_commit_message()->CopyFrom(message);
+
+  return NO_ERROR;
 }
 
 int64 BuildCommitCommand::FindAnchorPosition(syncable::IdField direction,
                                              const syncable::Entry& entry) {
   Id next_id = entry.Get(direction);
   while (!next_id.IsRoot()) {
     Entry next_entry(entry.trans(),
                      syncable::GET_BY_ID,
                      next_id);
     if (!next_entry.Get(IS_UNSYNCED) && !next_entry.Get(IS_UNAPPLIED_UPDATE)) {
@@ skipping 21 matching lines @@
   if (delta <= static_cast<uint64>(GetGap()*2))
     return lo + (static_cast<int64>(delta) + 7) / 8;  // Interpolate.
   else if (lo == GetFirstPosition())
     return hi - GetGap();  // Extend range just before successor.
   else
     return lo + GetGap();  // Use or extend range just after predecessor.
 }
 
 
 }  // namespace browser_sync