Add return values to SyncerCommand

chrome/browser/sync/engine/verify_updates_command.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/verify_updates_command.h"
 
 #include <string>
 
 #include "base/location.h"
 #include "chrome/browser/sync/engine/syncer.h"
@@ skipping 24 matching lines @@
       session.status_controller().updates_response().get_updates();
   for (int i = 0; i < updates.entries().size(); i++) {
     groups_with_updates.insert(
         GetGroupForModelType(syncable::GetModelType(updates.entries(i)),
                              session.routing_info()));
   }
 
   return groups_with_updates;
 }
 
-void VerifyUpdatesCommand::ModelChangingExecuteImpl(
+SyncerError VerifyUpdatesCommand::ModelChangingExecuteImpl(
     sessions::SyncSession* session) {
   DVLOG(1) << "Beginning Update Verification";
   ScopedDirLookup dir(session->context()->directory_manager(),
                       session->context()->account_name());
   if (!dir.good()) {
     LOG(ERROR) << "Scoped dir lookup failed!";
-    return;
+    return DIRECTORY_LOOKUP_FAILED;
   }
   WriteTransaction trans(FROM_HERE, SYNCER, dir);
   sessions::StatusController* status = session->mutable_status_controller();
   const GetUpdatesResponse& updates = status->updates_response().get_updates();
   int update_count = updates.entries().size();
 
   DVLOG(1) << update_count << " entries to verify";
   for (int i = 0; i < update_count; i++) {
     const SyncEntity& update =
         *reinterpret_cast<const SyncEntity *>(&(updates.entries(i)));
     ModelSafeGroup g = GetGroupForModelType(update.GetModelType(),
                                             session->routing_info());
     if (g != status->group_restriction())
       continue;
 
     VerifyUpdateResult result = VerifyUpdate(&trans, update,
                                              session->routing_info());
     status->mutable_update_progress()->AddVerifyResult(result.value, update);
     status->increment_num_updates_downloaded_by(1);
     if (update.deleted())
       status->increment_num_tombstone_updates_downloaded_by(1);
   }
+
+  return NO_ERROR;
 }
 
 namespace {
 // In the event that IDs match, but tags differ AttemptReuniteClient tag
 // will have refused to unify the update.
 // We should not attempt to apply it at all since it violates consistency
 // rules.
 VerifyResult VerifyTagConsistency(const SyncEntity& entry,
                                   const syncable::MutableEntry& same_id) {
   if (entry.has_client_defined_unique_tag() &&
@@ skipping 50 matching lines @@
         deleted, is_directory, model_type);
   }
 
   if (VERIFY_UNDECIDED == result.value)
     result.value = VERIFY_SUCCESS;  // No news is good news.
 
   return result;  // This might be VERIFY_SUCCESS as well
 }
 
 }  // namespace browser_sync