Fire canplaythrough as soon as download defers to fix autoplay

webkit/media/buffered_data_source.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/media/buffered_data_source.h"
 
 #include "base/bind.h"
 #include "media/base/media_log.h"
 #include "net/base/net_errors.h"
 #include "webkit/media/web_data_source_factory.h"
@@ skipping 580 matching lines @@
   if (error > 0) {
     // If a position error code is received, read was successful. So copy
     // from intermediate read buffer to the target read buffer.
     memcpy(read_buffer_, intermediate_read_buffer_.get(), error);
   } else if (error == 0 && total_bytes_ == kPositionNotSpecified) {
     // We've reached the end of the file and we didn't know the total size
     // before. Update the total size so Read()s past the end of the file will
     // fail like they would if we had known the file size at the beginning.
     total_bytes_ = loader_->instance_size();
 
     if (host() && total_bytes_ != kPositionNotSpecified) {

[acolwell GONE FROM CHROMIUM, 2012/01/05 22:33:56]

Consider updating this code to call UpdateHostState_Locked() to help keep host()
method call order consistent.

[vrk (LEFT CHROMIUM), 2012/01/09 19:01:18]

Done.

       host()->SetTotalBytes(total_bytes_);
       host()->SetBufferedBytes(total_bytes_);
     }
   }
   DoneRead_Locked(error);
 }
 
 void BufferedDataSource::NetworkEventCallback() {
   DCHECK(MessageLoop::current() == render_loop_);
   DCHECK(loader_.get());
@@ skipping 15 matching lines @@
   // method to prevent bad things from happening. The reason behind this is
   // that we cannot guarantee tasks on render thread have completely stopped
   // when we receive the Stop() method call. So only way to solve this is to
   // let tasks on render thread to run but make sure they don't call outside
   // this object when Stop() method is ever called. Locking this method is safe
   // because |lock_| is only acquired in tasks on render thread.
   base::AutoLock auto_lock(lock_);
   if (stop_signal_received_)
     return;
 
   if (is_downloading_data != is_downloading_data_) {

[acolwell GONE FROM CHROMIUM, 2012/01/05 22:33:56]

Consider updating this code to call UpdateHostState_Locked() to help keep host()
method call order consistent.

[vrk (LEFT CHROMIUM), 2012/01/09 19:01:18]

Done; I also had to change the unit tests to become more lenient about # of
times the various Set* methods got called.

     is_downloading_data_ = is_downloading_data;
     if (host())
       host()->SetNetworkActivity(is_downloading_data);
   }
 
   buffered_bytes_ = buffered_position + 1;
   if (host())
     host()->SetBufferedBytes(buffered_bytes_);
 }
 
 void BufferedDataSource::UpdateHostState_Locked() {
   // Called from various threads, under lock.
   lock_.AssertAcquired();
 
   if (!host())
     return;
 
   if (total_bytes_ != kPositionNotSpecified)
     host()->SetTotalBytes(total_bytes_);

[acolwell GONE FROM CHROMIUM, 2012/01/05 22:33:56]

Please make sure that download_rate_monitor unit tests mimic the same order that
these three methods are called in, just to make sure we don't miss any subtle
bugs related to their call order.

[vrk (LEFT CHROMIUM), 2012/01/09 19:01:18]

Done.

   host()->SetBufferedBytes(buffered_bytes_);
+  host()->SetNetworkActivity(is_downloading_data_);

[acolwell GONE FROM CHROMIUM, 2012/01/05 22:33:56]

Please update the BufferedDataSource unit test to check for this new behavior
and document why it is necessary.

[vrk (LEFT CHROMIUM), 2012/01/09 19:01:18]

Done.

 }
 
 }  // namespace webkit_media