Fix RTL and complex script title in print preview header/footer.

ui/gfx/render_text_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text_win.h"
 
 #include <algorithm>
 
 #include "base/i18n/break_iterator.h"
 #include "base/logging.h"
@@ skipping 99 matching lines @@
 
 }  // namespace internal
 
 RenderTextWin::RenderTextWin()
     : RenderText(),
       script_control_(),
       script_state_(),
       string_width_(0),
       needs_layout_(false) {
   // Omitting default constructors for script_* would leave POD uninitialized.
-  HRESULT hr = 0;
+  HRESULT hr = S_OK;
 
   // TODO(msw): Call ScriptRecordDigitSubstitution on WM_SETTINGCHANGE message.
   // TODO(msw): Use Chrome/profile locale/language settings?
   hr = ScriptRecordDigitSubstitution(LOCALE_USER_DEFAULT, &digit_substitute_);
-  DCHECK(SUCCEEDED(hr));
+  if (FAILED(hr)) {
+    LOG(WARNING) << "ScriptRecordDigitSubstitution failed " << hr

[vandebo (ex-Chrome), 2012/02/03 18:36:45]

Is it because of the sandbox?  Does that mean this code isn't safe to run in the
sandbox?  A Log isn't a good solution to the known.

+                 << ", possibly because of sandbox.";
+  }
 
-  hr = ScriptApplyDigitSubstitution(&digit_substitute_,
-                                    &script_control_,
-                                    &script_state_);
-  DCHECK(SUCCEEDED(hr));
-  script_control_.fMergeNeutralItems = true;
+  if (SUCCEEDED(hr)) {
+    hr = ScriptApplyDigitSubstitution(&digit_substitute_,

[vandebo (ex-Chrome), 2012/02/03 18:36:45]

Why is is ok to not so this in the sandbox?

+                                      &script_control_,
+                                      &script_state_);
+    DCHECK(SUCCEEDED(hr));
+    script_control_.fMergeNeutralItems = true;
+  }
 
   MoveCursorTo(EdgeSelectionModel(CURSOR_LEFT));
 }
 
 RenderTextWin::~RenderTextWin() {
   STLDeleteContainerPointers(runs_.begin(), runs_.end());
 }
 
 base::i18n::TextDirection RenderTextWin::GetTextDirection() {
   // TODO(benrg): Code moved from RenderText::GetTextDirection. Needs to be
@@ skipping 593 matching lines @@
     internal::TextRun* run) {
   size_t caret = IndexOfAdjacentGrapheme(run->range.end(), CURSOR_BACKWARD);
   return SelectionModel(caret, caret, SelectionModel::LEADING);
 }
 
 RenderText* RenderText::CreateRenderText() {
   return new RenderTextWin;
 }
 
 }  // namespace gfx