Fix RTL and complex script title in print preview header/footer.

chrome/renderer/print_web_view_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 27 matching lines @@
 #include "webkit/glue/webpreferences.h"
 
 #if defined(OS_POSIX)
 #include "base/process_util.h"
 #endif
 
 #if defined(USE_SKIA)
 #include "skia/ext/vector_canvas.h"
 #include "skia/ext/vector_platform_device_skia.h"
 #include "third_party/skia/include/core/SkTypeface.h"
+#if !defined(OS_MACOSX)  // USE_SKIA && !OS_MACOSX
+#include "ui/gfx/canvas_skia.h"
+#include "ui/gfx/render_text.h"
+#endif  // USE_SKIA && !defined(OS_MACOSX)
 #elif defined(OS_MACOSX)
 #include <CoreGraphics/CGContext.h>
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/sys_string_conversions.h"
 #include "ui/gfx/scoped_cg_context_save_gstate_mac.h"
 #endif
 
 #if defined(OS_MACOSX)
 using base::mac::ScopedCFTypeRef;
@@ skipping 325 matching lines @@
 void PrintHeaderFooterText(
     string16 text,
     WebKit::WebCanvas* canvas,
     HeaderFooterPaint paint,
     float webkit_scale_factor,
     const PageSizeMargins& page_layout,
     printing::HorizontalHeaderFooterPosition horizontal_position,
     printing::VerticalHeaderFooterPosition vertical_position,
     double offset_to_baseline) {
 #if defined(USE_SKIA)
+#if !defined(OS_MACOSX)  // RenderText does not support Mac yet.
+  scoped_ptr<gfx::RenderText> render_text(gfx::RenderText::CreateRenderText());
+  DCHECK(render_text.get());
+  render_text->SetText(text);
+  render_text->SetFontSize(printing::kSettingHeaderFooterFontSize);
+  gfx::CanvasSkia gfx_canvas(canvas);
+  SkISize device_size = gfx_canvas.GetSkCanvas()->getDeviceSize();
+  int height = render_text->GetFont().GetHeight() +
+               printing::kSettingHeaderFooterInterstice + 1;
+  int y = (vertical_position == printing::TOP) ? 1 - height :
+          device_size.height() - 1;
+  gfx::Rect rect(0, y, device_size.width(), height);

[vandebo (ex-Chrome), 2012/02/03 18:36:45]

As far as I can tell, this moves where the headers and footers are drawn and
doesn't take the webkit scale factor into consideration.  Grab me to explain if
I'm misunderstanding.

+  render_text->SetDisplayRect(rect);
+  switch (horizontal_position) {
+    case printing::LEFT:
+      render_text->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+      break;
+    case printing::RIGHT:
+      render_text->SetHorizontalAlignment(gfx::ALIGN_RIGHT);
+      break;
+    case printing::CENTER:
+      render_text->SetHorizontalAlignment(gfx::ALIGN_CENTER);
+      break;
+    default:
+      NOTREACHED();
+      break;
+  }
+  render_text->Draw(&gfx_canvas);
+#else
+  // TODO(arthurhsu): following code has issues with i18n BiDi, see
+  //                  crbug.com/108599.  Need to remove it and use RenderText
+  //                  code above once RenderText supports Mac.
   size_t text_byte_length = text.length() * sizeof(char16);
   double text_width_in_points = SkScalarToDouble(paint.measureText(
       text.c_str(), text_byte_length));
   SkPoint point = GetHeaderFooterPosition(webkit_scale_factor, page_layout,
                                           horizontal_position,
                                           vertical_position, offset_to_baseline,
                                           text_width_in_points);
   paint.setTextSize(SkDoubleToScalar(
       paint.getTextSize() / webkit_scale_factor));
   canvas->drawText(text.c_str(), text_byte_length, point.x(), point.y(),
                    paint);
+#endif  // USE_SKIA && !OS_MACOSX
 #elif defined(OS_MACOSX)
   ScopedCFTypeRef<CFStringRef> cf_text(base::SysUTF16ToCFStringRef(text));
   ScopedCFTypeRef<CFAttributedStringRef> cf_attr_text(
       CFAttributedStringCreate(NULL, cf_text, paint));
   ScopedCFTypeRef<CTLineRef> line(CTLineCreateWithAttributedString(
       cf_attr_text));
   double text_width_in_points =
       CTLineGetTypographicBounds(line, NULL, NULL, NULL) * webkit_scale_factor;
   SkPoint point = GetHeaderFooterPosition(webkit_scale_factor,
                                           page_layout, horizontal_position,
@@ skipping 1360 matching lines @@
   DCHECK(IsRendering());
   return prep_frame_view_->GetPrintCanvasSize();
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
   error_ = PREVIEW_ERROR_NONE;
 }