Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5268)

Unified Diff: chrome/browser/profiles/profile_impl.h

Issue 9111035: Profiles: Add a size check to ProfileImpl to make sure it no longer grows. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: comments from mirandac Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_impl.h
diff --git a/chrome/browser/profiles/profile_impl.h b/chrome/browser/profiles/profile_impl.h
index 2742279b8e5cc1d05dd99e6e876d66053bbf545c..01dfc362a735898fc5fe52ee49a02d2f0d85851e 100644
--- a/chrome/browser/profiles/profile_impl.h
+++ b/chrome/browser/profiles/profile_impl.h
@@ -316,6 +316,20 @@ class ProfileImpl : public Profile,
scoped_ptr<ChromeURLDataManager> chrome_url_data_manager_;
+ // STOP!!!! DO NOT ADD ANY MORE ITEMS HERE!!!!
+ //
+ // Instead, make your Service/Manager/whatever object you're hanging off the
+ // Profile use our new ProfileKeyedServiceFactory system instead. You can
+ // find the design document here:
+ //
+ // https://sites.google.com/a/chromium.org/dev/developers/design-documents/profile-architecture
+ //
+ // and you can read the raw headers here:
+ //
+ // chrome/browser/profile/profile_keyed_service.h
+ // chrome/browser/profile/profile_keyed_service_factory.{h,cc}
+ // chrome/browser/profile/profile_keyed_dependency_manager.{h,cc}
+
Profile::Delegate* delegate_;
chrome_browser_net::Predictor* predictor_;
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698