Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: chrome/browser/policy/file_based_policy_provider_unittest.cc

Issue 9111022: Removed ConfigurationPolicyType and extended PolicyMap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed builds, rebased Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/asynchronous_policy_loader.h" 5 #include "chrome/browser/policy/asynchronous_policy_loader.h"
6 #include "chrome/browser/policy/asynchronous_policy_test_base.h" 6 #include "chrome/browser/policy/asynchronous_policy_test_base.h"
7 #include "chrome/browser/policy/configuration_policy_pref_store.h" 7 #include "chrome/browser/policy/configuration_policy_pref_store.h"
8 #include "chrome/browser/policy/configuration_policy_provider.h" 8 #include "chrome/browser/policy/configuration_policy_provider.h"
9 #include "chrome/browser/policy/file_based_policy_provider.h" 9 #include "chrome/browser/policy/file_based_policy_provider.h"
10 #include "chrome/browser/policy/mock_configuration_policy_provider.h" 10 #include "chrome/browser/policy/mock_configuration_policy_provider.h"
11 #include "chrome/browser/policy/policy_map.h" 11 #include "chrome/browser/policy/policy_map.h"
(...skipping 19 matching lines...) Expand all
31 TEST_F(AsynchronousPolicyTestBase, ProviderInit) { 31 TEST_F(AsynchronousPolicyTestBase, ProviderInit) {
32 base::Time last_modified; 32 base::Time last_modified;
33 FileBasedPolicyProviderDelegateMock* provider_delegate = 33 FileBasedPolicyProviderDelegateMock* provider_delegate =
34 new FileBasedPolicyProviderDelegateMock(); 34 new FileBasedPolicyProviderDelegateMock();
35 EXPECT_CALL(*provider_delegate, GetLastModification()).WillRepeatedly( 35 EXPECT_CALL(*provider_delegate, GetLastModification()).WillRepeatedly(
36 Return(last_modified)); 36 Return(last_modified));
37 InSequence s; 37 InSequence s;
38 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return( 38 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(
39 new DictionaryValue)); 39 new DictionaryValue));
40 DictionaryValue* policies = new DictionaryValue(); 40 DictionaryValue* policies = new DictionaryValue();
41 policies->SetBoolean(policy::key::kSyncDisabled, true); 41 policies->SetBoolean(key::kSyncDisabled, true);
42 // A second call to Load gets triggered during the provider's construction 42 // A second call to Load gets triggered during the provider's construction
43 // when the file watcher is initialized, since this file may have changed 43 // when the file watcher is initialized, since this file may have changed
44 // between the initial load and creating watcher. 44 // between the initial load and creating watcher.
45 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(policies)); 45 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(policies));
46 FileBasedPolicyProvider provider(GetChromePolicyDefinitionList(), 46 FileBasedPolicyProvider provider(GetChromePolicyDefinitionList(),
47 POLICY_LEVEL_MANDATORY,
48 POLICY_SCOPE_USER,
Mattias Nissler (ping if slow) 2012/01/17 09:52:45 SCOPE_MACHINE for consistency?
Joao da Silva 2012/01/17 13:09:29 Done.
47 provider_delegate); 49 provider_delegate);
48 loop_.RunAllPending(); 50 loop_.RunAllPending();
49 PolicyMap policy_map; 51 PolicyMap policy_map;
50 provider.Provide(&policy_map); 52 provider.Provide(&policy_map);
51 EXPECT_TRUE(policy_map.Get(policy::kPolicySyncDisabled)); 53 EXPECT_TRUE(policy_map.Get(key::kSyncDisabled));
52 EXPECT_EQ(1U, policy_map.size()); 54 EXPECT_EQ(1U, policy_map.size());
53 } 55 }
54 56
55 TEST_F(AsynchronousPolicyTestBase, ProviderRefresh) { 57 TEST_F(AsynchronousPolicyTestBase, ProviderRefresh) {
56 base::Time last_modified; 58 base::Time last_modified;
57 FileBasedPolicyProviderDelegateMock* provider_delegate = 59 FileBasedPolicyProviderDelegateMock* provider_delegate =
58 new FileBasedPolicyProviderDelegateMock(); 60 new FileBasedPolicyProviderDelegateMock();
59 EXPECT_CALL(*provider_delegate, GetLastModification()).WillRepeatedly( 61 EXPECT_CALL(*provider_delegate, GetLastModification()).WillRepeatedly(
60 Return(last_modified)); 62 Return(last_modified));
61 InSequence s; 63 InSequence s;
62 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return( 64 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(
63 new DictionaryValue)); 65 new DictionaryValue));
64 FileBasedPolicyProvider file_based_provider(GetChromePolicyDefinitionList(), 66 FileBasedPolicyProvider file_based_provider(GetChromePolicyDefinitionList(),
67 POLICY_LEVEL_MANDATORY,
68 POLICY_SCOPE_USER,
65 provider_delegate); 69 provider_delegate);
66 // A second call to Load gets triggered during the provider's construction 70 // A second call to Load gets triggered during the provider's construction
67 // when the file watcher is initialized, since this file may have changed 71 // when the file watcher is initialized, since this file may have changed
68 // between the initial load and creating watcher. 72 // between the initial load and creating watcher.
69 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return( 73 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(
70 new DictionaryValue)); 74 new DictionaryValue));
71 loop_.RunAllPending(); 75 loop_.RunAllPending();
72 // A third and final call to Load is made by the explicit Reload. This 76 // A third and final call to Load is made by the explicit Reload. This
73 // should be the one that provides the current policy. 77 // should be the one that provides the current policy.
74 DictionaryValue* policies = new DictionaryValue(); 78 DictionaryValue* policies = new DictionaryValue();
75 policies->SetBoolean(policy::key::kSyncDisabled, true); 79 policies->SetBoolean(key::kSyncDisabled, true);
76 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(policies)); 80 EXPECT_CALL(*provider_delegate, Load()).WillOnce(Return(policies));
77 MockConfigurationPolicyObserver observer; 81 MockConfigurationPolicyObserver observer;
78 ConfigurationPolicyObserverRegistrar registrar; 82 ConfigurationPolicyObserverRegistrar registrar;
79 registrar.Init(&file_based_provider, &observer); 83 registrar.Init(&file_based_provider, &observer);
80 EXPECT_CALL(observer, OnUpdatePolicy(&file_based_provider)).Times(1); 84 EXPECT_CALL(observer, OnUpdatePolicy(&file_based_provider)).Times(1);
81 file_based_provider.RefreshPolicies(); 85 file_based_provider.RefreshPolicies();
82 loop_.RunAllPending(); 86 loop_.RunAllPending();
83 PolicyMap policy_map; 87 PolicyMap policy_map;
84 file_based_provider.Provide(&policy_map); 88 file_based_provider.Provide(&policy_map);
85 EXPECT_TRUE(policy_map.Get(policy::kPolicySyncDisabled)); 89 EXPECT_TRUE(policy_map.Get(key::kSyncDisabled));
86 EXPECT_EQ(1U, policy_map.size()); 90 EXPECT_EQ(1U, policy_map.size());
87 } 91 }
88 92
89 } // namespace policy 93 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698