Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 9111020: Merge 101903 - REGRESSION (r91125): Polyline tool in google docs is broken (Closed)

Created:
8 years, 11 months ago by dglazkov
Modified:
8 years, 11 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 101903 - REGRESSION (r91125): Polyline tool in google docs is broken https://bugs.webkit.org/show_bug.cgi?id=65796 Source/WebCore: Patch by Stephen Chenney <schenney@chromium.org>; on 2011-12-02 Reviewed by Darin Adler. Work around a bug in CoreGraphics, that caused incorrect bounds for paths consisting only of move-to elements. This causes problems in SVG, when the enormous bounds prevented the drawing of things behind. Tests: svg/custom/path-moveto-only-rendering.svg svg/custom/subpaths-moveto-only-rendering.svg * platform/graphics/cg/PathCG.cpp: (WebCore::PathIsEmptyOrSingleMoveTester::PathIsEmptyOrSingleMoveTester): Class to test for isEmpty accoridng ot the same rules as other platforms. (WebCore::PathIsEmptyOrSingleMoveTester::isEmpty): Query the result (WebCore::PathIsEmptyOrSingleMoveTester::testPathElement): Path iterator method (WebCore::PathHasOnlyMoveToTester::PathHasOnlyMoveToTester): Class to test whether a path contains only move-to elements, and hence should have null bounds. (WebCore::PathHasOnlyMoveToTester::hasOnlyMoveTo): Query the result (WebCore::PathHasOnlyMoveToTester::testPathElement): Path iterator method. (WebCore::Path::boundingRect): Modified to check for move-to only paths (WebCore::Path::fastBoundingRect): Modified to check for move-to only paths (WebCore::Path::isEmpty): Now uses the method that matches other platforms. (WebCore::Path::hasCurrentPoint): Now uses CGPathIsEmpty directly (WebCore::Path::transform) : Now uses CGPathIsEmpty directly LayoutTests: Work around a bug in CoreGraphics, that caused incorrect bounds for paths consisting only of move-to elements. This causes problems in SVG, when the enormous bounds prevented the drawing of things behind. Will revert expectation file when expectations are stable. Patch by Stephen Chenney <schenney@chromium.org>; on 2011-12-02 Reviewed by Darin Adler. * platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed. * platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt: Removed. * platform/mac/svg/custom/path-moveto-only-rendering-expected.png: Added. * platform/mac/svg/custom/path-moveto-only-rendering-expected.txt: Added. * platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png: Added. * platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt: Added. * svg/custom/path-moveto-only-rendering.svg: Added. * svg/custom/subpaths-moveto-only-rendering.svg: Added. * svg/custom/zero-path-square-cap-rendering2-expected.txt: Modified text output * platform/chromium/test_expectations.txt: Added flakiness for new tests from this patch TBR=commit-queue@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -7905 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +0 lines, -2637 lines 0 comments Download
D LayoutTests/platform/chromium-mac/svg/custom/zero-path-square-cap-rendering2-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/platform/chromium-win/svg/custom/zero-path-square-cap-rendering2-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/platform/mac/svg/custom/path-moveto-only-rendering-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/custom/path-moveto-only-rendering-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/custom/subpaths-moveto-only-rendering-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/path-moveto-only-rendering.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/custom/subpaths-moveto-only-rendering.svg View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/svg/custom/zero-path-square-cap-rendering2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -5256 lines 0 comments Download
M Source/WebCore/platform/graphics/cg/PathCG.cpp View 5 chunks +78 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dglazkov
8 years, 11 months ago (2012-01-05 18:18:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698