Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9111008: Introduce PPB_ResourceArray_Dev. (Closed)

Created:
8 years, 11 months ago by yzshen1
Modified:
8 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Introduce PPB_ResourceArray_Dev. TEST=test_resource_array.{h,cc} BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116789

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change PPB_ResourceArray_Shared to use std::vector. #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+660 lines, -7 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A ppapi/api/dev/ppb_resource_array_dev.idl View 1 chunk +65 lines, -0 lines 0 comments Download
A ppapi/c/dev/ppb_resource_array_dev.h View 1 2 1 chunk +85 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/resource_array_dev.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ppapi/cpp/dev/resource_array_dev.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 3 chunks +11 lines, -1 line 0 comments Download
A ppapi/shared_impl/ppb_resource_array_shared.h View 1 1 chunk +54 lines, -0 lines 0 comments Download
A ppapi/shared_impl/ppb_resource_array_shared.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download
M ppapi/shared_impl/resource.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 2 chunks +2 lines, -1 line 0 comments Download
A ppapi/tests/test_resource_array.h View 1 chunk +28 lines, -0 lines 0 comments Download
A ppapi/tests/test_resource_array.cc View 1 chunk +123 lines, -0 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_resource_array_api.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ppapi/thunk/ppb_resource_array_thunk.cc View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 4 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Brett. Please take a look. Thanks!
8 years, 11 months ago (2012-01-05 08:24:48 UTC) #1
brettw
http://codereview.chromium.org/9111008/diff/1/ppapi/shared_impl/ppb_resource_array_shared.h File ppapi/shared_impl/ppb_resource_array_shared.h (right): http://codereview.chromium.org/9111008/diff/1/ppapi/shared_impl/ppb_resource_array_shared.h#newcode45 ppapi/shared_impl/ppb_resource_array_shared.h:45: PP_Resource* elements_; Why not just use a std::vector<PP_Resource> here ...
8 years, 11 months ago (2012-01-05 22:32:28 UTC) #2
yzshen1
http://codereview.chromium.org/9111008/diff/1/ppapi/shared_impl/ppb_resource_array_shared.h File ppapi/shared_impl/ppb_resource_array_shared.h (right): http://codereview.chromium.org/9111008/diff/1/ppapi/shared_impl/ppb_resource_array_shared.h#newcode45 ppapi/shared_impl/ppb_resource_array_shared.h:45: PP_Resource* elements_; Done. I used a raw buffer because ...
8 years, 11 months ago (2012-01-06 18:20:10 UTC) #3
brettw
lgtm
8 years, 11 months ago (2012-01-06 18:41:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/9111008/16001
8 years, 11 months ago (2012-01-06 23:32:45 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-07 00:51:05 UTC) #6 
Change committed as 116789

Powered by Google App Engine
This is Rietveld 408576698