Issue 9110045: Change IDL shim/wrapper generator to use version numbers in struct names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9110045: Change IDL shim/wrapper generator to use version numbers in struct names. (Closed)

Created:
8 years, 11 months ago by jvoung - send to chromium...

Modified:
8 years, 11 months ago

Reviewers:
noelallen1, Roland McGrath

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change IDL shim/wrapper generator to use version numbers in struct names. This is to match recent changes in the PPAPI generated headers in the following change: http://codereview.chromium.org/8989006/ R=noelallen@chromium.org,mcgrathr@chromium.org BUG= none TEST= compile the pnacl irt shim and use it in a test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116836

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	ppapi/generators/idl_gen_wrapper.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	ppapi/generators/test_gen_pnacl/test_interfaces.idl	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

jvoung - send to chromium...

Roland, this should fix the bug (one of the bugs?) blocking the chrome roll.

8 years, 11 months ago (2012-01-06 23:50:22 UTC) #2

Roland McGrath

I don't know this code so as to give a meaningful review. LGTM if you're ...

8 years, 11 months ago (2012-01-07 00:14:27 UTC) #3

LGTM