Chromium Code Reviews

Issue 9110044: chromeos/aura: Handle power button on unofficial hardware. (Closed)

Created:
8 years, 11 months ago by Daniel Erat
Modified:
8 years, 11 months ago
Reviewers:
Ben Goodger (Google)
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

chromeos/aura: Handle power button on unofficial hardware. Most official Chrome OS hardware reports power button releases correctly, but on standard x86 systems, we'll always receive a button up event just after the button down. This change adds a chromeos_legacy_power_button gyp flag; when set, we lock the screen or shut down immediately when the button is pressed instead of providing interactive animations. BUG=109209 TEST=added tests; also did manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116993

Patch Set 1 #

Patch Set 2 : show background on shutdown and move gyp variable to a different scope #

Unified diffs Side-by-side diffs Stats (+100 lines, -0 lines)
M ash/wm/power_button_controller.cc View 4 chunks +18 lines, -0 lines 0 comments
M ash/wm/power_button_controller_unittest.cc View 2 chunks +75 lines, -0 lines 0 comments
M build/common.gypi View 2 chunks +7 lines, -0 lines 0 comments

Messages

Total messages: 2 (0 generated)
Daniel Erat
8 years, 11 months ago (2012-01-09 23:24:58 UTC) #1
Ben Goodger (Google)
8 years, 11 months ago (2012-01-09 23:28:56 UTC) #2
lgtm

Powered by Google App Engine