Issue 9110029: Fix test-hashing after recent changes to string hashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9110029: Fix test-hashing after recent changes to string hashing. (Closed)

Created:
8 years, 11 months ago by Erik Corry

Modified:
8 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix test-hashing after recent changes to string hashing. Acriave test-hashing in SCons and buildbot runs. Small cleanups in root register handling on ARM and MIPS. Committed: http://code.google.com/p/v8/source/detail?r=10351

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -55 lines)			Patch
M	src/arm/builtins-arm.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/builtins-mips.cc	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	src/mips/deoptimizer-mips.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/mips/lithium-gap-resolver-mips.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	test/cctest/SConscript	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-hashing.cc	View	3 chunks	+35 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 11 months ago (2012-01-06 10:52:56 UTC) #2

LGTM with comment.

http://codereview.chromium.org/9110029/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):

http://codereview.chromium.org/9110029/diff/1/src/mips/builtins-mips.cc#newco...
src/mips/builtins-mips.cc:1119: // Set up the roots register.
Isn't this part supposed to be replaced by InitializeRootRegister()?

Expand Messages | Collapse Messages