Some cleanups to Frog to avoid looking up its builtin types too much

utils/apidoc/html_diff.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A script to assist in documenting the difference between the dart:html API
  * and the old DOM API.
  */
 #library('html_diff');
 
@@ skipping 18 matching lines @@
       var htmlTypeName = htmlMember.declaringType.name;
       var htmlName = '$htmlTypeName.${htmlMember.name}';
       if (htmlMember.isConstructor || htmlMember.isFactory) {
         final separator = htmlMember.constructorName == '' ? '' : '.';
         htmlName = 'new $htmlTypeName$separator${htmlMember.constructorName}';
       }
       print('${domMember.declaringType.name}.${domMember.name} -> ${htmlName}');
     }
   });
 
-  for (var type in world.dom.types.getValues()) {
+  for (var type in diff.dom.types.getValues()) {

[Jennifer Messerly, 2012/01/06 21:36:29]

I was trying to get rid of "world.dom" completely. Ended up not being able to
kill it just yet, but it's still good IMHO good to avoid depending on that
field.

     if (type.name == null) continue;
     if (type.definition is FunctionTypeDefinition) continue;
     for (var member in type.members.getValues()) {
       if (!member.isPrivate && member.name != 'typeName' &&
           !diff.domToHtml.containsKey(member) &&
           (member is MethodMember || member is PropertyMember)) {
         print('No dart:html wrapper for ${type.name}.${member.name}');
       }
     }
   }
@@ skipping 28 matching lines @@
   final Map<Member, Set<Member>> htmlToDom;
 
   /** A map from `dart:dom` types to corresponding `dart:html` types. */
   final Map<Type, Set<Type>> domTypesToHtml;
 
   /** A map from `dart:html` types to corresponding `dart:dom` types. */
   final Map<Type, Set<Type>> htmlTypesToDom;
 
   final CommentMap comments;
 
+  final Library dom;
+
   /**
    * Perform static initialization of [world]. This should be run before
    * calling [HtmlDiff.run].
    */
   static void initialize() {
     world.processDartScript('dart:htmlimpl');
     world.resolveAll();
+    dom = world.libraries['dart:dom'];
   }
 
   HtmlDiff() :
     domToHtml = new Map<Member, Set<Member>>(),
     htmlToDom = new Map<Member, Set<Member>>(),
     domTypesToHtml = new Map<Type, Set<Type>>(),
     htmlTypesToDom = new Map<Type, Set<Type>>(),
     comments = new CommentMap();
 
   /**
@@ skipping 115 matching lines @@
   List<Type> htmlToDomTypes(Type htmlType) {
     if (htmlType.name == null) return [];
     final tags = _getTags(comments.find(htmlType.span));
 
     if (tags.containsKey('domName')) {
       var domNames = map(tags['domName'].split(','), (s) => s.trim());
       if (domNames.length == 1 && domNames[0] == 'none') return [];
       return map(domNames, (domName) {
         // DOMWindow is Chrome-specific, so we don't use it in our annotations.
         if (domName == 'Window') domName = 'DOMWindow';
-        final domType = world.dom.types[domName];
+        final domType = dom.types[domName];
         if (domType == null) print('Warning: no dart:dom type named $domName');
         return domType;
       });
     } else {
       if (!htmlType.name.endsWith('WrappingImplementation')) return [];
       final domName = htmlType.name.replaceFirst('WrappingImplementation', '');
-      var domType = world.dom.types[domName];
+      var domType = dom.types[domName];
       if (domType == null && domName.endsWith('Element')) {
-        domType = world.dom.types['HTML$domName'];
+        domType = dom.types['HTML$domName'];
       }
-      if (domType == null) domType = world.dom.types['WebKit$domName'];
+      if (domType == null) domType = dom.types['WebKit$domName'];
       if (domType == null) {
         print('Warning: no dart:dom type matches dart:htmlimpl ' +
             htmlType.name);
         return [];
       }
       return [domType];
     }
   }
 
   /**
@@ skipping 61 matching lines @@
       return members;
     }
 
     final splitName = name.split('.');
     if (splitName.length != 2) {
       print('Warning: invalid member name ${name}');
       return new Set();
     }
     var typeName = splitName[0];
     if (typeName == 'Window') typeName = 'DOMWindow';
-    final type = world.dom.types[typeName];
+    final type = dom.types[typeName];
     if (type == null) return new Set();
     final member = type.members[splitName[1]];
     if (member == null) return new Set();
     return new Set.from([member]);
   }
 
   /**
    * Returns the `dart:dom` [Member]s that are referred to in [stmt]. This only
    * extracts references from relatively simple statements; methods containing
    * more complex wrappers should be manually annotated with `@domName`.
@@ skipping 91 matching lines @@
   Map<String, String> _getTags(String comment) {
     if (comment == null) return const <String>{};
     final re = new RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)");
     final tags = <String>{};
     for (var m in re.allMatches(comment.trim())) {
       tags[m[1]] = m[2];
     }
     return tags;
   }
 }