Some cleanups to Frog to avoid looking up its builtin types too much

frog/corejs.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Generates JS helpers for dart:core. This used to be in a file "core.js".
  * Having them in Dart code means we can easily control which are generated.
  */
 // TODO(jmesserly): one idea to make this cleaner: put these as private "native"
 // methods somewhere in a library that we import. This would be rather elegant
@@ skipping 83 matching lines @@
     writer.writeln(_DYNAMIC_FUNCTION);
   }
 
   void ensureTypeNameOf() {
     if (_generatedTypeNameOf) return;
     _generatedTypeNameOf = true;
     writer.writeln(_TYPE_NAME_OF_FUNCTION);
   }
 
   /** Generates the $inherits function when it's first used. */
-  ensureInheritsHelper() {
+  void ensureInheritsHelper() {
     if (_generatedInherits) return;
     _generatedInherits = true;
     writer.writeln(_INHERITS_FUNCTION);
   }
 
   void generate(CodeWriter w) {
     // Write any stuff we had queued up, then replace our writer with the one
     // in WorldGenerator so anything we discover that we need later on will be
     // generated on-demand.
     w.write(writer.text);
@@ skipping 30 matching lines @@
       }
       if (useWrap1) {
         w.writeln(_EMPTY_WRAP_CALL1_FUNCTION);
       }
     }
 
     // Write operator helpers
     for (var opImpl in orderValuesByKeys(_usedOperators)) {
       w.writeln(opImpl);
     }
+
+    if (world.dom != null) {
+      ensureTypeNameOf();
+      // TODO(jmesserly): we need to find a way to avoid conflicts with other
+      // generated "typeName" fields. Ideally we wouldn't be patching 'Object'
+      // here.
+      w.writeln('Object.prototype.get\$typeName = ' +
+          ' Object.prototype.\$typeNameOf;');
+    }
   }
 }
 
 
 /** Snippet for `$ne`. */
 final String _NE_FUNCTION = @"""
 function $ne(x, y) {
   if (x == null) return y != null;
   return (typeof(x) == 'number' && typeof(y) == 'number') ||
          (typeof(x) == 'boolean' && typeof(y) == 'boolean') ||
@@ skipping 126 matching lines @@
     for (var j = 0; j < tagNames.length; j++) {
       map[tagNames[j]] = true;
     }
     table.push({tag: tag, tags: tags, map: map});
   }
   $dynamicMetadata = table;
 }
 """;
 
 /** Snippet for `$typeNameOf`. */
-// TODO(sigmund): find a way to make this work on all browsers, including
-// checking the typeName on prototype objects (so we can fix dynamic
-// dispatching on $varMethod).
 final String _TYPE_NAME_OF_FUNCTION = @"""
 Object.prototype.$typeNameOf = function() {
   if ((typeof(window) != 'undefined' && window.constructor.name == 'DOMWindow')
       || typeof(process) != 'undefined') { // fast-path for Chrome and Node
     return this.constructor.name;
   }
   var str = Object.prototype.toString.call(this);
   str = str.substring(8, str.length - 1);
   if (str == 'Window') {
     str = 'DOMWindow';
@@ skipping 127 matching lines @@
 
 /** Snippet for `$wrap_call$1`, in case it was not necessary. */
 final String _EMPTY_WRAP_CALL1_FUNCTION =
     @"function $wrap_call$1(fn) { return fn; }";
 
 /** Snippet that initializes the isolates state. */
 final String _ISOLATE_INIT_CODE = @"""
 var $globalThis = this;
 var $globals = null;
 var $globalState = null;""";