Issue 9110017: AppCache: Use WeakPtr instead of base::Unretained for DiskCache callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9110017: AppCache: Use WeakPtr instead of base::Unretained for DiskCache callbacks. (Closed)

Created:
8 years, 11 months ago by James Hawkins

Modified:
8 years, 11 months ago

Reviewers:
michaeln, awong

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

AppCache: Use WeakPtr instead of base::Unretained for DiskCache callbacks. BUG=109077, 109068 TEST=none R=michaeln,awong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116621

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	webkit/appcache/appcache_response.cc	View		4 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

michaeln

Pulling some comments over from the old CL (http://codereview.chromium.org/9064007/) > I think you're right, but ...

8 years, 11 months ago (2012-01-05 23:36:47 UTC) #3

michaeln

8 years, 11 months ago (2012-01-05 23:51:51 UTC) #4

LGTM

Like we chatted about, i'll take care of the CreateBackend call in a seperate
CL.