Issue 9109028: GTK: Another GTK deprecation patch.

Issue 9109028: GTK: Another GTK deprecation patch. (Closed)

Created:
8 years, 11 months ago by Elliot Glaysher

Modified:
8 years, 11 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, asanka, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Randy Smith (Not in Mondays)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

GTK: Another GTK deprecation patch. BUG=79722 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116602

Patch Set 2 : Remove chromeos file #

Total comments: 2

Patch Set 3 : evanm fix #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -18 lines)			Patch
M	chrome/browser/ui/gtk/download/download_item_gtk.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/find_bar_gtk.cc	View		3 chunks	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_chrome_link_button.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/gtk_custom_menu_item.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/menu_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/reload_button_gtk.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/rounded_window.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/tab_contents_container_gtk.cc	View	1 2	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Elliot Glaysher

To quickly get you up to speed: I'm currently going through the entire gtk port, ...

8 years, 11 months ago (2012-01-05 22:40:56 UTC) #1

Evan Martin

LGTM but I'm pretty sure you need to fix the last file. http://codereview.chromium.org/9109028/diff/2001/chrome/browser/ui/gtk/tab_contents_container_gtk.cc File chrome/browser/ui/gtk/tab_contents_container_gtk.cc ...

8 years, 11 months ago (2012-01-05 22:50:37 UTC) #2

Elliot Glaysher

http://codereview.chromium.org/9109028/diff/2001/chrome/browser/ui/gtk/tab_contents_container_gtk.cc File chrome/browser/ui/gtk/tab_contents_container_gtk.cc (right): http://codereview.chromium.org/9109028/diff/2001/chrome/browser/ui/gtk/tab_contents_container_gtk.cc#newcode168 chrome/browser/ui/gtk/tab_contents_container_gtk.cc:168: GtkWidget* parent = gtk_widget_get_parent(widget); On 2012/01/05 22:50:37, Evan Martin ...

8 years, 11 months ago (2012-01-05 23:19:49 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/9109028/1011

8 years, 11 months ago (2012-01-05 23:20:27 UTC) #4

Change committed as 116602

Expand Messages | Collapse Messages