Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 9109001: Add CSS as a source file type. (Closed)

Created:
8 years, 11 months ago by Evan Stade
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Add CSS as a source file type. this forces license headers, no line-end whitespace, etc. Also update the default license header regex to allow concluding */ on the final line. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119448

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M presubmit_canned_checks.py View 1 1 chunk +1 line, -1 line 0 comments Download
M presubmit_support.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/presubmit_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
I don't know how to send this to trybots. Presubmit locally gives me some crazy ...
8 years, 11 months ago (2012-01-24 22:38:39 UTC) #1
Marc-Antoine Ruel (Google)
lgtm, I'll check the cq bit tomorrow morning since I won't be there tonight in ...
8 years, 11 months ago (2012-01-25 00:13:37 UTC) #2
Evan Stade
ping that cq bit
8 years, 11 months ago (2012-01-27 00:15:26 UTC) #3
M-A Ruel
On 2012/01/27 00:15:26, Evan Stade wrote: > ping that cq bit Argh I totally forgot. ...
8 years, 11 months ago (2012-01-27 01:12:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9109001/2001
8 years, 11 months ago (2012-01-27 14:38:26 UTC) #5
commit-bot: I haz the power
Presubmit check for 9109001-2001 failed and returned exit status 1. warning: code.google.com certificate with fingerprint ...
8 years, 11 months ago (2012-01-27 14:44:23 UTC) #6
M-A Ruel
lgtm
8 years, 11 months ago (2012-01-27 14:45:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/9109001/2001
8 years, 11 months ago (2012-01-27 14:45:17 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-27 14:51:14 UTC) #9
Change committed as 119448

Powered by Google App Engine
This is Rietveld 408576698