vm/object.cc - Issue 9108036: - Remove redundant initialization in Array::New

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: vm/object.cc

Issue 9108036: - Remove redundant initialization in Array::New (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Patch Set: Created 8 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: vm/object.cc

===================================================================

--- vm/object.cc (revision 3009)

+++ vm/object.cc (working copy)

@@ -7112,9 +7112,7 @@

NoGCScope no_gc;

result ^= raw;

result.SetLength(len);

- for (intptr_t i = 0; i < len; i++) {

- *result.ObjectAddr(i) = Object::null();

- }

+ // Object::Allocate has already initialized the allocated area.

Ivan Posva 2012/01/06 21:40:05 Comment can be dropped, no?

siva 2012/01/07 00:01:02 Done.

}

return result.raw();

}

« no previous file with comments | « vm/dart.cc ('k') | vm/timer.h » ('j') | no next file with comments »