Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 9108030: trychange.py: make --sub_rep work again (Closed)

Created:
8 years, 11 months ago by dgrogan
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Alexei Svitkine (slow)
Visibility:
Public.

Description

trychange.py: make --sub_rep work again It appears to have been broken in http://crrev.com/104148 BUG=102205 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116723

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M trychange.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dgrogan
Marc-Antoine, could you review this? I ran into this when trying to submit a try ...
8 years, 11 months ago (2012-01-06 00:13:52 UTC) #1
Marc-Antoine Ruel (Google)
please upload another patchset with style fixed then lgtm. http://codereview.chromium.org/9108030/diff/2001/trychange.py File trychange.py (right): http://codereview.chromium.org/9108030/diff/2001/trychange.py#newcode700 trychange.py:700: ...
8 years, 11 months ago (2012-01-06 02:41:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9108030/5002
8 years, 11 months ago (2012-01-06 19:45:23 UTC) #3
commit-bot: I haz the power
Presubmit check for 9108030-5002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 11 months ago (2012-01-06 19:52:26 UTC) #4
M-A Ruel
gna. lgtm
8 years, 11 months ago (2012-01-06 19:53:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/9108030/5002
8 years, 11 months ago (2012-01-06 19:53:42 UTC) #6
commit-bot: I haz the power
8 years, 11 months ago (2012-01-06 20:01:14 UTC) #7
Change committed as 116723

Powered by Google App Engine
This is Rietveld 408576698