Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1239)

Unified Diff: content/public/browser/download_manager.h

Issue 9108024: Cleanup parameter passing issues in content/browser/download (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove fix for CID 102890 Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/mock_download_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/download_manager.h
diff --git a/content/public/browser/download_manager.h b/content/public/browser/download_manager.h
index c123cc05a6d3d61528c419a8fc4896558f7c98e8..ef948b94e86d4d03ec294c2f15db1a178d3d6a7d 100644
--- a/content/public/browser/download_manager.h
+++ b/content/public/browser/download_manager.h
@@ -108,7 +108,7 @@ class CONTENT_EXPORT DownloadManager
virtual void UpdateDownload(int32 download_id,
int64 bytes_so_far,
int64 bytes_per_sec,
- std::string hash_state) = 0;
+ const std::string& hash_state) = 0;
// |download_id| is the ID of the download.
// |size| is the number of bytes that have been downloaded.
@@ -129,7 +129,7 @@ class CONTENT_EXPORT DownloadManager
// |reason| is a download interrupt reason code.
virtual void OnDownloadInterrupted(int32 download_id,
int64 size,
- std::string hash_state,
+ const std::string& hash_state,
InterruptReason reason) = 0;
// Called when the download is renamed to its final name.
« no previous file with comments | « content/browser/download/mock_download_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698