Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: runtime/bin/process.dart

Issue 9108008: Add optional workingDirectory argument to Process.start. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/process.dart
===================================================================
--- runtime/bin/process.dart (revision 2981)
+++ runtime/bin/process.dart (working copy)
@@ -7,12 +7,14 @@
* Creates a new process object and starts a process running the executable
* found at [path] with the specified [arguments]. When the process has
* been successfully started the [startHandler] is called. If the process
- * fails to start the [errorHandler] is called.
+ * fails to start the [errorHandler] is called. An optional
+ * [workingDirectory] can be passed to specify where the process is run
+ * from.
Søren Gjesse 2012/01/05 09:30:47 I think there should be some additional info on th
Anders Johnsen 2012/01/05 09:50:49 Nice observation, added further comments.
*
* No data can be written to the process stdin and the process cannot be
* closed nor killed before the [startHandler] has been invoked.
*/
- Process.start(String path, List<String> arguments);
+ Process.start(String path, List<String> arguments, [String workingDirectory]);
Søren Gjesse 2012/01/05 09:30:47 Maybe we should rename path to executable.
Anders Johnsen 2012/01/05 09:50:49 Agreed.
/**
* Returns an input stream of the process stdout.

Powered by Google App Engine
This is Rietveld 408576698