Add optional workingDirectory argument to Process.start.

runtime/bin/process_impl.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _ProcessStartStatus {
   int _errorCode;  // Set to OS error code if process start failed.
   String _errorMessage;  // Set to OS error message if process start failed.
 }
 
 
 class _Process implements Process {
 
-  _Process.start(String path, List<String> arguments) {
+  _Process.start(String path, List<String> arguments, [String workingDirectory]) {

[Søren Gjesse, 2012/01/05 09:30:47]

Ling line, do either

_Process.start(
    String path, List<String> arguments, [String workingDirectory]) {
  ...
}

or

_Process.start(String path,
               List<String> arguments,
               [String workingDirectory]) {
  ...
}

[Anders Johnsen, 2012/01/05 09:50:49]

Done.

     if (path is !String) {
       throw new ProcessException("Path is not a String: $path");
     }
     _path = path;
 
     if (arguments is !List) {
       throw new ProcessException("Arguments is not a List: $arguments");
     }
     int len = arguments.length;
     _arguments = new ObjectArray<String>(len);
     for (int i = 0; i < len; i++) {
       var arg = arguments[i];
       if (arg is !String) {
         throw new ProcessException("Non-string argument: $arg");
       }
       _arguments[i] = arguments[i];
     }
 
+    if (workingDirectory is !String && workingDirectory !== null) {
+      throw new ProcessException(
+          "WorkingDirectory is not a String: $workingDirectory");
+    }
+    _workingDirectory = workingDirectory;
+
     _in = new _Socket._internalReadOnly();  // stdout coming from process.
     _out = new _Socket._internalWriteOnly();  // stdin going to process.
     _err = new _Socket._internalReadOnly();  // stderr coming from process.
     _exitHandler = new _Socket._internalReadOnly();
     _closed = false;
     _killed = false;
     _started = false;
     _exitHandlerCallback = null;
     // TODO(ager): Make the actual process starting really async instead of
     // simulating it with a timer.
     new Timer((Timer ignore) => start(), 0);
   }
 
   int _intFromBytes(List<int> bytes, int offset) {
     return (bytes[offset] +
             (bytes[offset + 1] << 8) +
             (bytes[offset + 2] << 16) +
             (bytes[offset + 3] << 24));
   }
 
   void start() {
     var status = new _ProcessStartStatus();
     bool success = _start(

[Søren Gjesse, 2012/01/05 09:30:47]

When all arguments cannot fit on one line they should each be on separate lines.

It is not mandated by
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...,
but we usually do.

[Anders Johnsen, 2012/01/05 09:50:49]

Nice to know, ty!

-        _path, _arguments, _in, _out, _err, _exitHandler, status);
+        _path, _arguments, _workingDirectory, _in, _out, _err, _exitHandler, 
+        status);
     if (!success) {
       close();
       if (_errorHandler !== null) {
         _errorHandler(new ProcessException(status._errorMessage,
                                            status._errorCode));
         return;
       }
     }
     _started = true;
 
@@ skipping 33 matching lines @@
       if (exitDataRead == EXIT_DATA_SIZE) handleExit();
     };
 
     if (_startHandler !== null) {
       _startHandler();
     }
   }
 
   bool _start(String path,
               List<String> arguments,
+              String workingDirectory,
               Socket input,
               Socket output,
               Socket error,
               Socket exitHandler,
               _ProcessStartStatus status) native "Process_Start";
 
   void _processExit(int pid) native "Process_Exit";
 
   InputStream get stdout() {
     if (_closed) {
@@ skipping 61 matching lines @@
   void set errorHandler(void callback(ProcessException exception)) {
     _errorHandler = callback;
   }
 
   void set startHandler(void callback()) {
     _startHandler = callback;
   }
 
   String _path;
   ObjectArray<String> _arguments;
+  String _workingDirectory;
   Socket _in;
   Socket _out;
   Socket _err;
   Socket _exitHandler;
   int _pid;
   bool _closed;
   bool _killed;
   bool _started;
   Function _exitHandlerCallback;
   Function _errorHandler;
   Function _startHandler;
 }