Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: tests/language/src/NamingTest.dart

Issue 9107070: Proper handling of built-in identifiers (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/src/NamingTest.dart
===================================================================
--- tests/language/src/NamingTest.dart (revision 3272)
+++ tests/language/src/NamingTest.dart (working copy)
@@ -182,10 +182,6 @@
return () { return x + 1; };
}
siva 2012/01/13 18:48:20 I guess you removed this because it is a duplicate
hausner 2012/01/13 19:22:47 Yes, the test was just wrong.
- negate(x) {
- return () { return x + 2; };
- }
-
operator[] (x) {
return () { return x + 3; };
}
@@ -195,7 +191,7 @@
Expect.equals(1, (h.f_)());
var f = -h;
Expect.equals(4, f());
- Expect.equals(6, h.negate(4)());
+ Expect.equals(4, h.negate()());
Expect.equals(7, h[4]());
}
}
@@ -518,21 +514,8 @@
}
siva 2012/01/13 18:48:20 Ditto comment.
hausner 2012/01/13 19:22:47 Ditto answer.
}
-// Ensure we don't have false positivesj.
-class Naming3Test {
- Naming3Test() { }
- operator negate() { }
- negate() => 777;
-
- static void main(args) {
- var a = new Naming3Test();
- Expect.equals(777, a.negate());
- }
-}
-
main() {
NamingTest.testMain();
Naming1Test.main(null);
Naming2Test.main(null);
- Naming3Test.main(null);
}

Powered by Google App Engine
This is Rietveld 408576698