Don't animate the default/background layer if there is no background.

because there is nothing behind it and a browser ends up being blended with webkit's default background  (which is blue in dbg build)

BUG=108701
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117812

[James Cook, 2012-01-13 00:42:12]

http://codereview.chromium.org/9107068/diff/1/chrome/browser/chromeos/login/b...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/9107068/diff/1/chrome/browser/chromeos/login/b...
chrome/browser/chromeos/login/base_login_display_host.cc:332: if
(kEnableBackgroundAnimation) {
Should this also check IsWindowModeCompact()?  Compact window mode doesn't have
a background to animate either.  (This probably works right now because
kEnableBackgroundAnimation is always false.)

[oshima, 2012-01-13 00:59:51]

Changed to check if there is any background window per offline discussion. PTAL.

On 2012/01/13 00:42:12, James Cook (Chromium) wrote:
>
http://codereview.chromium.org/9107068/diff/1/chrome/browser/chromeos/login/b...
> File chrome/browser/chromeos/login/base_login_display_host.cc (right):
> 
>
http://codereview.chromium.org/9107068/diff/1/chrome/browser/chromeos/login/b...
> chrome/browser/chromeos/login/base_login_display_host.cc:332: if
> (kEnableBackgroundAnimation) {
> Should this also check IsWindowModeCompact()?  Compact window mode doesn't
have
> a background to animate either.  (This probably works right now because
> kEnableBackgroundAnimation is always false.)

[James Cook, 2012-01-13 01:06:51]

LGTM, one typo in comment

http://codereview.chromium.org/9107068/diff/3002/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/9107068/diff/3002/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/base_login_display_host.cc:335: // default and and
background layer because there is nothing behind it.
"and and" -> "and" (or maybe "or" :-)

[oshima, 2012-01-13 01:12:01]

http://codereview.chromium.org/9107068/diff/3002/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/9107068/diff/3002/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/base_login_display_host.cc:335: // default and and
background layer because there is nothing behind it.
On 2012/01/13 01:06:51, James Cook (Chromium) wrote:
> "and and" -> "and" (or maybe "or" :-)
> 
oops, sorry. done.

[commit-bot: I haz the power, 2012-01-13 01:12:12]

No LGTM from valid reviewers yet.

[oshima, 2012-01-13 01:24:19]

dave, nikita, can one of you approve this?

[Nikita (slow), 2012-01-13 10:16:29]

This one fixes part of http://code.google.com/p/chromium/issues/detail?id=108701

http://codereview.chromium.org/9107068/diff/5003/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/9107068/diff/5003/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/base_login_display_host.cc:376:
scoped_ptr<ui::LayerAnimationElement> br
Please fix.

[oshima, 2012-01-13 18:35:57]

http://codereview.chromium.org/9107068/diff/5003/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/base_login_display_host.cc (right):

http://codereview.chromium.org/9107068/diff/5003/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/base_login_display_host.cc:376:
scoped_ptr<ui::LayerAnimationElement> br
On 2012/01/13 10:16:30, Nikita Kostylev wrote:
> Please fix.

oops. done.

[Nikita (slow), 2012-01-14 18:24:56]

lgtm

[Nikita (slow), 2012-01-14 18:25:51]

I've linked this CL to 108701

lgtm

[commit-bot: I haz the power, 2012-01-14 23:29:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/9107068/8001

[commit-bot: I haz the power, 2012-01-15 00:46:59]

Change committed as 117812