Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ppapi/cpp/var_array_buffer.h

Issue 9107046: PPAPI: Move PPB_ArrayBuffer out of Dev. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: minor fixes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/cpp/dev/var_array_buffer_dev.cc ('k') | ppapi/cpp/var_array_buffer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/var_array_buffer.h
diff --git a/ppapi/cpp/dev/var_array_buffer_dev.h b/ppapi/cpp/var_array_buffer.h
similarity index 72%
rename from ppapi/cpp/dev/var_array_buffer_dev.h
rename to ppapi/cpp/var_array_buffer.h
index 6f7c18af2a6334691f52cb7e9ccfd6b3b45cb2ff..0c97d99f2aee33100ee8a147d3fad3a55dfa2801 100644
--- a/ppapi/cpp/dev/var_array_buffer_dev.h
+++ b/ppapi/cpp/var_array_buffer.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef PPAPI_CPP_DEV_VAR_ARRAY_BUFFER_DEV_H_
-#define PPAPI_CPP_DEV_VAR_ARRAY_BUFFER_DEV_H_
+#ifndef PPAPI_CPP_VAR_ARRAY_BUFFER_H_
+#define PPAPI_CPP_VAR_ARRAY_BUFFER_H_
#include "ppapi/cpp/var.h"
@@ -12,31 +12,37 @@
namespace pp {
-/// VarArrayBuffer_Dev provides a way to interact with JavaScript ArrayBuffers,
+/// VarArrayBuffer provides a way to interact with JavaScript ArrayBuffers,
/// which represent a contiguous sequence of bytes. Note that
-/// VarArrayBuffer_Devs are not part of the embedding page's DOM, and can only
+/// VarArrayBuffers are not part of the embedding page's DOM, and can only
/// be shared with JavaScript via pp::Instance's PostMessage and HandleMessage
/// functions.
-class VarArrayBuffer_Dev : public Var {
+class VarArrayBuffer : public Var {
public:
- /// Contruct a VarArrayBuffer_Dev given a var for which is_array_buffer() is
+ /// Contruct a VarArrayBuffer given a var for which is_array_buffer() is
/// true. This will refer to the same ArrayBuffer as var, but allows you to
- /// access methods specific to VarArrayBuffer_Dev.
+ /// access methods specific to VarArrayBuffer.
///
/// @param[in] var An ArrayBuffer Var.
- explicit VarArrayBuffer_Dev(const Var& var);
+ explicit VarArrayBuffer(const Var& var);
+
+ /// Construct a new VarArrayBuffer_Dev which is size_in_bytes bytes long and
+ /// initialized to zero.
+ ///
+ /// @param[in] size_in_bytes The size of the constructed ArrayBuffer in bytes.
+ explicit VarArrayBuffer(uint32_t size_in_bytes);
/// Copy constructor.
- VarArrayBuffer_Dev(const VarArrayBuffer_Dev& buffer) : Var(buffer) {}
+ VarArrayBuffer(const VarArrayBuffer& buffer) : Var(buffer) {}
- virtual ~VarArrayBuffer_Dev() {}
+ virtual ~VarArrayBuffer() {}
/// This function assigns one VarArrayBuffer to another VarArrayBuffer.
///
/// @param[in] other The VarArrayBuffer to be assigned.
///
/// @return The resulting VarArrayBuffer.
- VarArrayBuffer_Dev& operator=(const VarArrayBuffer_Dev& other);
+ VarArrayBuffer& operator=(const VarArrayBuffer& other);
/// This function assigns one VarArrayBuffer to another VarArrayBuffer. Var's
/// assignment operator is overloaded here so that we can check for assigning
@@ -47,15 +53,9 @@ class VarArrayBuffer_Dev : public Var {
/// @return The resulting VarArrayBuffer (as a Var&).
virtual Var& operator=(const Var& other);
- /// Construct a new VarArrayBuffer_Dev which is size_in_bytes bytes long and
- /// initialized to zero.
- ///
- /// @param[in] size_in_bytes The size of the constructed ArrayBuffer in bytes.
- VarArrayBuffer_Dev(uint32_t size_in_bytes);
-
- /// Return the length of the VarArrayBuffer_Dev in bytes.
+ /// Return the length of the VarArrayBuffer in bytes.
///
- /// @return The length of the VarArrayBuffer_Dev in bytes.
+ /// @return The length of the VarArrayBuffer in bytes.
uint32_t ByteLength() const;
/// Maps the ArrayBuffer in to the module's address space and returns a
@@ -82,4 +82,4 @@ class VarArrayBuffer_Dev : public Var {
} // namespace pp
-#endif // PPAPI_CPP_DEV_VAR_ARRAY_BUFFER_DEV_H_
+#endif // PPAPI_CPP_VAR_ARRAY_BUFFER_H_
« no previous file with comments | « ppapi/cpp/dev/var_array_buffer_dev.cc ('k') | ppapi/cpp/var_array_buffer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698