Issue 9104028: Unfork various Sync settings UI classes

Issue 9104028: Unfork various Sync settings UI classes (Closed)

Created:
8 years, 10 months ago by Andrew T Wilson (Slow)

Modified:
8 years, 10 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Unfork various Sync settings UI classes Removing some of the prematurely-forked sync settings code, to make it easier to perform refactoring of the sync APIs. BUG=111859 TEST=Make sure sync signin and settings still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119972

Patch Set 1 #

Patch Set 2 : Fixed cros error #

Patch Set 3 : Merge with ToT. #

Patch Set 4 : Another cros compilation fix. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1095 lines)			Patch
M	chrome/browser/ui/webui/options2/chromeos/accounts_options_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/keyboard_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/language_chewing_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/language_hangul_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/language_mozc_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/pointer_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/proxy_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/stats_options_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/virtual_keyboard_manager_handler2.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/webui/options2/options_sync_setup_handler2.h	View		1 chunk	+0 lines, -26 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/options_sync_setup_handler2.cc	View		1 chunk	+0 lines, -61 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/options_ui2.h	View		2 chunks	+1 line, -62 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/options_ui2.cc	View		3 chunks	+2 lines, -40 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/stop_syncing_handler2.h	View		1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/stop_syncing_handler2.cc	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	chrome/browser/ui/webui/sync_setup_handler2.h	View		1 chunk	+0 lines, -121 lines	0 comments	Download
D	chrome/browser/ui/webui/sync_setup_handler2.cc	View	1 2	1 chunk	+0 lines, -674 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	3 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

This is that unforking we talked about yesterday. PTAL.

8 years, 10 months ago (2012-01-31 20:29:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/9104028/5003

8 years, 10 months ago (2012-01-31 20:50:50 UTC) #3

Change committed as 119972

Expand Messages | Collapse Messages