Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 9104022: Reduced logging and better log format for PyAuto WaitUntil(). (Closed)

Created:
8 years, 10 months ago by dtu
Modified:
8 years, 10 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, John Grabowski, anantha, dyu1
Visibility:
Public.

Description

Reduced logging and better log format for PyAuto WaitUntil(). Since most calls to WaitUntil use lambdas, you commonly see a lot of: DEBUG WaitUntil(<function <lambda> at 0x79b984c4>) still waiting. Expecting None. Last returned False. With this change it is instead: DEBUG WaitUntil(pyauto.py:281 self.WaitUntil(lambda: _AreOrigPidsDead(orig_pids))) still waiting. Expecting True. Last returned False. Also reduce the frequency to once every 5 seconds. BUG=None. TEST=Run any PyAuto test that uses WaitUntil(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119974

Patch Set 1 #

Patch Set 2 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -15 lines) Patch
M chrome/test/pyautolib/pyauto.py View 1 10 chunks +25 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dtu
8 years, 10 months ago (2012-01-31 00:03:15 UTC) #1
Nirnimesh
LGTM. Awesome!
8 years, 10 months ago (2012-01-31 00:18:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/9104022/1
8 years, 10 months ago (2012-01-31 00:26:52 UTC) #3
commit-bot: I haz the power
Can't apply patch for file chrome/test/pyautolib/pyauto.py. While running patch -p1 --forward --force; patching file chrome/test/pyautolib/pyauto.py ...
8 years, 10 months ago (2012-01-31 00:26:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/9104022/5001
8 years, 10 months ago (2012-01-31 01:22:12 UTC) #5
commit-bot: I haz the power
Try job failure for 9104022-5001 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 10 months ago (2012-01-31 02:37:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtu@chromium.org/9104022/5001
8 years, 10 months ago (2012-01-31 19:58:44 UTC) #7
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 22:31:13 UTC) #8
Change committed as 119974

Powered by Google App Engine
This is Rietveld 408576698